rename to excluded_members

Author: janeklb

github/resource_github_team_settings.go

@@ -129,7 +129,7 @@ func resourceGithubTeamSettings() *schema.Resource {
 							Default:     false,
 							Description: "whether to notify the entire team when at least one member is also assigned to the pull request.",
 						},
-						"excluded_team_members": {
+						"excluded_members": {
 							Type:        schema.TypeSet,
 							Optional:    true,
 							Description: "A list of team member usernames to exclude from the PR review process.",
@@ -235,7 +235,7 @@ func resourceGithubTeamSettingsUpdate(d *schema.ResourceData, meta any) error {
 			}
 
 			exclusionList := make([]githubv4.ID, 0)
-			if excludedMembers, ok := settings["excluded_team_members"]; ok && excludedMembers != nil {
+			if excludedMembers, ok := settings["excluded_members"]; ok && excludedMembers != nil {
 				// Collect all usernames first
 				usernames := make([]string, 0)
 				for _, v := range excludedMembers.(*schema.Set).List() {

github/resource_github_team_settings_test.go

@@ -138,7 +138,7 @@ func TestAccGithubTeamSettings(t *testing.T) {
 					algorithm = "ROUND_ROBIN"
 					member_count = 1
 					notify = true
-					excluded_team_members = ["octocat", "defunkt"]
+					excluded_members = ["octocat", "defunkt"]
 				}
 			}
 		`, teamName)
@@ -149,7 +149,7 @@ func TestAccGithubTeamSettings(t *testing.T) {
 				"ROUND_ROBIN",
 			),
 			resource.TestCheckResourceAttr(
-				"github_team_settings.test", "review_request_delegation.0.excluded_team_members.#",
+				"github_team_settings.test", "review_request_delegation.0.excluded_members.#",
 				"2",
 			),
 		)

website/docs/r/team_settings.html.markdown

@@ -11,7 +11,7 @@ This resource manages the team settings (in particular the request review delega
 
 Creating this resource will alter the team Code Review settings.
 
-The team must both belong to the same organization configured in the provider on GitHub. 
+The team must both belong to the same organization configured in the provider on GitHub.
 
 ~> **Note**: This resource relies on the v4 GraphQl GitHub API. If this API is not available, or the Stone Crop schema preview is not available, then this resource will not work as intended.
 
@@ -30,7 +30,7 @@ resource "github_team_settings" "code_review_settings" {
       algorithm = "ROUND_ROBIN"
       member_count = 1
       notify = true
-      excluded_team_members = ["octocat", "defunkt"]
+      excluded_members = ["octocat", "defunkt"]
   }
 }
 ```
@@ -39,18 +39,17 @@ resource "github_team_settings" "code_review_settings" {
 
 The following arguments are supported:
 
-* `team_id` - (Required) The GitHub team id or the GitHub team slug
-* `review_request_delegation` - (Optional) The settings for delegating code reviews to individuals on behalf of the team. If this block is present, even without any fields, then review request delegation will be enabled for the team. See [GitHub Review Request Delegation](#github-review-request-delegation-configuration) below for details. See [GitHub's documentation](https://docs.github.com/en/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team#configuring-team-notifications) for more configuration details.
+- `team_id` - (Required) The GitHub team id or the GitHub team slug
+- `review_request_delegation` - (Optional) The settings for delegating code reviews to individuals on behalf of the team. If this block is present, even without any fields, then review request delegation will be enabled for the team. See [GitHub Review Request Delegation](#github-review-request-delegation-configuration) below for details. See [GitHub's documentation](https://docs.github.com/en/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team#configuring-team-notifications) for more configuration details.
 
 ### GitHub Review Request Delegation Configuration
 
 The following arguments are supported:
 
-* `algorithm` - (Optional) The algorithm to use when assigning pull requests to team members. Supported values are `ROUND_ROBIN` and `LOAD_BALANCE`. Default value is `ROUND_ROBIN`
-* `member_count` - (Optional) The number of team members to assign to a pull request
-* `notify` - (Optional) whether to notify the entire team when at least one member is also assigned to the pull request
-* `excluded_team_members` - (Optional) A list of team member usernames to exclude from the PR review process.
-
+- `algorithm` - (Optional) The algorithm to use when assigning pull requests to team members. Supported values are `ROUND_ROBIN` and `LOAD_BALANCE`. Default value is `ROUND_ROBIN`
+- `member_count` - (Optional) The number of team members to assign to a pull request
+- `notify` - (Optional) whether to notify the entire team when at least one member is also assigned to the pull request
+- `excluded_members` - (Optional) A list of team member usernames to exclude from the PR review process.
 
 ## Import
 
@@ -59,7 +58,9 @@ GitHub Teams can be imported using the GitHub team ID, or the team slug e.g.
 ```
 $ terraform import github_team.code_review_settings 1234567
 ```
+
 or,
+
 ```
 $ terraform import github_team_settings.code_review_settings SomeTeam
-```
+```