Replace pointers with accessors

Signed-off-by: Timo Sand <[email protected]>

Author: deiga

github/resource_github_repository.go

@@ -686,7 +686,7 @@ func resourceGithubRepositoryCreate(ctx context.Context, d *schema.ResourceData,
 				return diag.FromErr(err)
 			}
 
-			d.SetId(*repo.Name)
+			d.SetId(repo.GetName())
 		}
 	} else if d.Get("fork").(string) == "true" {
 		// Handle repository forking
@@ -758,6 +758,7 @@ func resourceGithubRepositoryCreate(ctx context.Context, d *schema.ResourceData,
 	}
 
 	archived := d.Get("archived").(bool)
+	// If the repository is archived on creation, we need to skip calling Update to avoid 403 errors
 	if archived {
 		tflog.Debug(ctx, "Repository archived, skipping modifying topics, pages, visibility, and vulnerability alerts", map[string]any{
 			"owner":      meta.(*Owner).name,
@@ -939,6 +940,13 @@ func resourceGithubRepositoryUpdate(ctx context.Context, d *schema.ResourceData,
 		return nil
 	}
 
+	tflog.Debug(ctx, "Updating repository", map[string]any{
+		"owner":           meta.(*Owner).name,
+		"repository":      d.Id(),
+		"archived":        d.Get("archived").(bool),
+		"archived_change": d.HasChange("archived"),
+	})
+
 	client := meta.(*Owner).v3client
 
 	repoReq := resourceGithubRepositoryObject(d)
@@ -988,7 +996,7 @@ func resourceGithubRepositoryUpdate(ctx context.Context, d *schema.ResourceData,
 	if err != nil {
 		return diag.FromErr(err)
 	}
-	d.SetId(*repo.Name)
+	d.SetId(repo.GetName())
 
 	if d.HasChange("pages") && !d.IsNewResource() {
 		opts := expandPagesUpdate(d.Get("pages").([]any))
@@ -1016,15 +1024,15 @@ func resourceGithubRepositoryUpdate(ctx context.Context, d *schema.ResourceData,
 
 	if d.HasChange("topics") {
 		topics := repoReq.Topics
-		_, _, err = client.Repositories.ReplaceAllTopics(ctx, owner, *repo.Name, topics)
+		_, _, err = client.Repositories.ReplaceAllTopics(ctx, owner, repo.GetName(), topics)
 		if err != nil {
 			return diag.FromErr(err)
 		}
-		d.SetId(*repo.Name)
+		d.SetId(repo.GetName())
 
 		if d.HasChange("topics") {
 			topics := repoReq.Topics
-			_, _, err = client.Repositories.ReplaceAllTopics(ctx, owner, *repo.Name, topics)
+			_, _, err = client.Repositories.ReplaceAllTopics(ctx, owner, repo.GetName(), topics)
 			if err != nil {
 				return diag.FromErr(err)
 			}
@@ -1136,7 +1144,7 @@ func expandPagesUpdate(input []any) *github.PagesUpdate {
 	// must include the branch name and optionally the subdirectory /docs.
 	// e.g. "master" or "master /docs"
 	// This is only necessary if the BuildType is "legacy".
-	if update.BuildType == nil || *update.BuildType == "legacy" {
+	if update.BuildType == nil || update.GetBuildType() == "legacy" {
 		pagesSource := pages["source"].([]any)[0].(map[string]any)
 		sourceBranch := pagesSource["branch"].(string)
 		sourcePath := ""