fix(environments): swallow 404 not found errors (#3132)

acouvreur · web-flow · commit d09bfd44a9e7 · 2026-02-03T10:53:13.000Z
When an environment no longer exist, the deletion call should not throw back an error.

The resource is in the desired state, gone.
diff --git a/github/resource_github_repository_environment.go b/github/resource_github_repository_environment.go
@@ -240,7 +240,7 @@ func resourceGithubRepositoryEnvironmentDelete(ctx context.Context, d *schema.Re
 
 	_, err = client.Repositories.DeleteEnvironment(ctx, owner, repoName, url.PathEscape(envName))
 	if err != nil {
-		return diag.FromErr(err)
+		return diag.FromErr(deleteResourceOn404AndSwallow304OtherwiseReturnError(err, d, "environment (%s)", envName))
 	}
 
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ func resourceGithubRepositoryEnvironmentDelete(ctx context.Context, d *schema.Re`
`240`	`240`
`241`	`241`	`_, err = client.Repositories.DeleteEnvironment(ctx, owner, repoName, url.PathEscape(envName))`
`242`	`242`	`if err != nil {`
`243`		`- return diag.FromErr(err)`
	`243`	`+ return diag.FromErr(deleteResourceOn404AndSwallow304OtherwiseReturnError(err, d, "environment (%s)", envName))`
`244`	`244`	`}`
`245`	`245`
`246`	`246`	`return nil`