Skip to content

Commit c7594f7

Browse files
Fix nil pointer dereference when commit_message is not set
The Update and Delete functions were dereferencing opts.Message without checking for nil, which could cause a panic when users don't specify a commit_message in their configuration. Added nil checks before dereferencing to use default messages when no custom message is provided.
1 parent b31b1d7 commit c7594f7

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

github/resource_github_repository_file.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ func resourceGithubRepositoryFileUpdate(d *schema.ResourceData, meta any) error
440440
return err
441441
}
442442

443-
if *opts.Message == fmt.Sprintf("Add %s", file) {
443+
if opts.Message == nil || *opts.Message == fmt.Sprintf("Add %s", file) {
444444
m := fmt.Sprintf("Update %s", file)
445445
opts.Message = &m
446446
}
@@ -483,7 +483,7 @@ func resourceGithubRepositoryFileDelete(d *schema.ResourceData, meta any) error
483483
return err
484484
}
485485

486-
if *opts.Message == fmt.Sprintf("Add %s", file) {
486+
if opts.Message == nil || *opts.Message == fmt.Sprintf("Add %s", file) {
487487
m := fmt.Sprintf("Delete %s", file)
488488
opts.Message = &m
489489
}

0 commit comments

Comments
 (0)