test: Remove standalone SDK validation tests, covered by InternalValidate in consistency test

Co-Authored-By: Claude <[email protected]>

Author: ei-grad

github/resource_github_etag_unit_test.go

@@ -1,7 +1,6 @@
 package github
 
 import (
-	"strings"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
@@ -72,60 +71,6 @@ func TestEtagDiffSuppressFunction(t *testing.T) {
 	}
 }
 
-// TestEtagComputedOnlyRejectsSuppress verifies that the SDK rejects
-// DiffSuppressFunc on Computed-only fields, proving Optional is required.
-func TestEtagComputedOnlyRejectsSuppress(t *testing.T) {
-	p := &schema.Provider{
-		ResourcesMap: map[string]*schema.Resource{
-			"test": {
-				Schema: map[string]*schema.Schema{
-					"etag": {
-						Type:     schema.TypeString,
-						Computed: true,
-						DiffSuppressFunc: func(k, o, n string, d *schema.ResourceData) bool {
-							return true
-						},
-						DiffSuppressOnRefresh: true,
-					},
-				},
-			},
-		},
-	}
-	err := p.InternalValidate()
-	if err == nil {
-		t.Fatal("expected SDK to reject DiffSuppressFunc on Computed-only field")
-	}
-	if !strings.Contains(err.Error(), "DiffSuppressFunc") {
-		t.Fatalf("unexpected error: %s", err)
-	}
-}
-
-// TestEtagOptionalComputedAcceptsSuppress verifies that the SDK accepts
-// DiffSuppressFunc on Optional+Computed fields.
-func TestEtagOptionalComputedAcceptsSuppress(t *testing.T) {
-	p := &schema.Provider{
-		ResourcesMap: map[string]*schema.Resource{
-			"test": {
-				Schema: map[string]*schema.Schema{
-					"etag": {
-						Type:     schema.TypeString,
-						Optional: true,
-						Computed: true,
-						DiffSuppressFunc: func(k, o, n string, d *schema.ResourceData) bool {
-							return true
-						},
-						DiffSuppressOnRefresh: true,
-					},
-				},
-			},
-		},
-	}
-	err := p.InternalValidate()
-	if err != nil {
-		t.Fatalf("Optional+Computed with DiffSuppressFunc should be valid, got: %s", err)
-	}
-}
-
 // TestEtagSchemaConsistency ensure DiffSuppressFunc and DiffSuppressOnRefresh are consistently applied.
 func TestEtagSchemaConsistency(t *testing.T) {
 	resourcesWithEtag := map[string]*schema.Resource{