aaa

Signed-off-by: Steve Hipwell <[email protected]>

Author: stevehipwell

.github/workflows/dotcom-acceptance-tests.yaml

@@ -37,18 +37,18 @@ jobs:
       - name: Checkout
         uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
 
-      - name: Check secrets
-        env:
-          INPUT_ALLOWED_SECRETS: ${{ vars.DOTCOM_ACCEPTANCE_TESTS_ALLOWED_SECRETS || 'DOTCOM_TEST_USER_TOKEN' }}
-          INPUT_SECRETS: ${{ toJSON(secrets) }}
-        run: |
-          set -eou pipefail
+      # - name: Check secrets
+      #   env:
+      #     INPUT_ALLOWED_SECRETS: ${{ vars.DOTCOM_ACCEPTANCE_TESTS_ALLOWED_SECRETS || 'DOTCOM_TEST_USER_TOKEN' }}
+      #     INPUT_SECRETS: ${{ toJSON(secrets) }}
+      #   run: |
+      #     set -eou pipefail
 
-          secret_keys="$(jq --raw-output --compact-output '[. | keys[] | select(test("^(?:(?:TEST)|(?:test))_") | not)] | sort | join(",")' <<<"${INPUT_SECRETS}")"
-          if [[ "${secret_keys}" != "${INPUT_ALLOWED_SECRETS}" ]]; then
-            echo "::error::Too many or too few secrets configured: ${secret_keys}"
-            exit 1
-          fi
+      #     secret_keys="$(jq --raw-output --compact-output '[. | keys[] | select(test("^(?:(?:ACTIONS)|(?:actions)|(?:GITHUB)|(?:github)|(?:TEST)|(?:test))_") | not)] | sort | join(",")' <<<"${INPUT_SECRETS}")"
+      #     if [[ "${secret_keys}" != "${INPUT_ALLOWED_SECRETS}" ]]; then
+      #       echo "::error::Too many or too few secrets configured: ${secret_keys}"
+      #       exit 1
+      #     fi
 
       - name: Check credentials
         id: credentials
@@ -75,6 +75,7 @@ jobs:
         env:
           TF_ACC: "1"
           TF_LOG: INFO
+          GITHUB_TOKEN: ${{ steps.credentials.outputs.token }}
           GITHUB_BASE_URL: https://api.github.com/
           GITHUB_TEST_TYPE: ${{ matrix.mode }}
           GITHUB_OWNER: ${{ (matrix.mode == 'individual' && 'github-terraform-test-user') || (matrix.mode == 'organization' && 'terraformtesting') || '' }}

.github/workflows/ghes-acceptance-tests.yaml

@@ -36,7 +36,7 @@ jobs:
         run: |
           set -eou pipefail
 
-          secret_keys="$(jq --raw-output --compact-output '[. | keys[] | select(test("^(?:(?:TEST)|(?:test))_") | not)] | sort | join(",")' <<<"${INPUT_SECRETS}")"
+          secret_keys="$(jq --raw-output --compact-output '[. | keys[] | select(test("^(?:(?:ACTIONS)|(?:actions)|(?:GITHUB)|(?:github)|(?:TEST)|(?:test))_") | not)] | sort | join(",")' <<<"${INPUT_SECRETS}")"
           if [[ "${secret_keys}" != "${INPUT_ALLOWED_SECRETS}" ]]; then
             echo "::error::Too many or too few secrets configured: ${secret_keys}"
             exit 1
@@ -89,6 +89,7 @@ jobs:
         env:
           TF_ACC: "1"
           TF_LOG: INFO
+          GITHUB_TOKEN: ${{ steps.credentials.outputs.token }}
           GITHUB_BASE_URL: ${{ steps.server.outputs.address }}
           GITHUB_TEST_TYPE: enterprise
           GITHUB_OWNER: terraformtesting

github/config.go

@@ -2,6 +2,7 @@ package github
 
 import (
 	"context"
+	"fmt"
 	"net/http"
 	"net/url"
 	"path"
@@ -103,7 +104,7 @@ func (c *Config) NewRESTClient(client *http.Client) (*github.Client, error) {
 
 	hostname := uv3.Hostname()
 	if hostname != DotComHost && !GHECDataResidencyHostMatch.MatchString(hostname) {
-		uv3.Path = path.Join(uv3.Path, "api/v3/")
+		uv3.Path = fmt.Sprintf("%s/", path.Join(uv3.Path, "api/v3"))
 	}
 
 	v3client, err := github.NewClient(client).WithEnterpriseURLs(uv3.String(), "")