Address review comments

Signed-off-by: Timo Sand <[email protected]>

Author: deiga

github/resource_github_repository_test.go

@@ -386,36 +386,30 @@ func TestAccGithubRepository(t *testing.T) {
 	t.Run("configures_topics_for_a_repository", func(t *testing.T) {
 		randomID := acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum)
 		testRepoName := fmt.Sprintf("%stopic-%s", testResourcePrefix, randomID)
-		config := fmt.Sprintf(`
+		topicsBefore := `["terraform", "testing"]`
+		topicsAfter := `["terraform", "testing", "extra-topic"]`
+		config := `
 			resource "github_repository" "test" {
 				name        = "%s"
 				description = "Terraform acceptance tests %[1]s"
-				topics			= ["terraform", "testing"]
+				topics			= %s
 			}
-		`, testRepoName)
+		`
 
 		resource.Test(t, resource.TestCase{
 			PreCheck:          func() { skipUnauthenticated(t) },
 			ProviderFactories: providerFactories,
 			Steps: []resource.TestStep{
 				{
-					Config: config,
+					Config: fmt.Sprintf(config, testRepoName, topicsBefore),
 					Check: resource.ComposeTestCheckFunc(
-						resource.TestCheckResourceAttr(
-							"github_repository.test", "topics.#",
-							"2",
-						),
+						resource.TestCheckResourceAttr("github_repository.test", "topics.#", "2"),
 					),
 				},
 				{
-					Config: strings.Replace(config,
-						`topics			= ["terraform", "testing"]`,
-						`topics			= ["terraform", "testing", "extra-topic"]`, 1),
+					Config: fmt.Sprintf(config, testRepoName, topicsAfter),
 					Check: resource.ComposeTestCheckFunc(
-						resource.TestCheckResourceAttr(
-							"github_repository.test", "topics.#",
-							"3",
-						),
+						resource.TestCheckResourceAttr("github_repository.test", "topics.#", "3"),
 					),
 				},
 			},