chore: add schema validations

- Add ValidateDiagFunc to required schema fields for early validation in plan phase
- Add validation import to resource_github_enterprise_team_membership
- This allows users to get validation errors during plan instead of apply

Author: github-actions[bot]

github/resource_github_enterprise_team.go

@@ -36,11 +36,13 @@ func resourceGithubEnterpriseTeam() *schema.Resource {
 				Required:    true,
 				ForceNew:    true,
 				Description: "The slug of the enterprise (e.g. from the enterprise URL).",
+				ValidateDiagFunc: validation.ToDiagFunc(validation.StringLenBetween(1, 255)),
 			},
 			"name": {
 				Type:        schema.TypeString,
 				Required:    true,
 				Description: "The name of the enterprise team.",
+				ValidateDiagFunc: validation.ToDiagFunc(validation.StringLenBetween(1, 255)),
 			},
 			"description": {
 				Type:        schema.TypeString,

github/resource_github_enterprise_team_membership.go

@@ -10,6 +10,7 @@ import (
 	githubv3 "github.com/google/go-github/v67/github"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 )
 
 func resourceGithubEnterpriseTeamMembership() *schema.Resource {
@@ -25,19 +26,22 @@ func resourceGithubEnterpriseTeamMembership() *schema.Resource {
 				Required:    true,
 				ForceNew:    true,
 				Description: "The slug of the enterprise.",
+				ValidateDiagFunc: validation.ToDiagFunc(validation.StringLenBetween(1, 255)),
 			},
 			"enterprise_team": {
 				Type:        schema.TypeString,
 				Required:    true,
 				ForceNew:    true,
 				Description: "The slug or ID of the enterprise team.",
+				ValidateDiagFunc: validation.ToDiagFunc(validation.StringLenBetween(1, 255)),
 			},
 			"username": {
 				Type:             schema.TypeString,
 				Required:         true,
 				ForceNew:         true,
 				DiffSuppressFunc: caseInsensitive(),
 				Description:      "The login handle of the user.",
+				ValidateDiagFunc: validation.ToDiagFunc(validation.StringLenBetween(1, 255)),
 			},
 		},
 	}