fix(lint): resolve last linter issues

Signed-off-by: Timo Sand <[email protected]>

Author: deiga

GNUmakefile

@@ -53,9 +53,11 @@ tf-provider-lint:
 	tfproviderlintx \
 		-AT001=false \
 		-AT003=false \
+		-AT004=false \
 		-AT006=false \
 		-XAT001=false \
 		-XR003=false \
+		-XR007=false \
 		-XS002=false \
 		$(TEST)
 

github/resource_github_etag_unit_test.go

@@ -14,7 +14,7 @@ func TestEtagDiffSuppressFunction(t *testing.T) {
 
 	if etagField == nil {
 		t.Fatal("etag field not found in repository schema")
-		panic("unreachable") // This resolves https://github.com/golangci/golangci-lint/issues/5979
+		panic("unreachable") // lintignore:R009 // This resolves https://github.com/golangci/golangci-lint/issues/5979
 	}
 
 	if etagField.DiffSuppressFunc == nil {

github/resource_github_user_invitation_accepter.go

@@ -10,6 +10,7 @@ import (
 )
 
 func resourceGithubUserInvitationAccepter() *schema.Resource {
+	// lintignore:XR002
 	return &schema.Resource{
 		Description: "Accepts a repository invitation for the authenticated user.",
 		Create:      resourceGithubUserInvitationAccepterCreate,

github/transport.go

@@ -283,7 +283,7 @@ func (t *RetryTransport) RoundTrip(req *http.Request) (*http.Response, error) {
 			return resp, err
 		}
 
-		time.Sleep(t.retryDelay)
+		time.Sleep(t.retryDelay) // lintignore:R018
 	}
 
 	return resp, err

github/util_v4_repository_test.go

@@ -117,15 +117,15 @@ func TestGetRepositoryIDPositiveMatches(t *testing.T) {
 	responses := template.Must(template.New("node_match").Parse(nodeMatchTmpl))
 	_, err := responses.New("node_no_match").Parse(nodeNoMatchTmpl)
 	if err != nil {
-		panic(err)
+		t.Fatal(err)
 	}
 	_, err = responses.New("repo_match").Parse(repoMatchTmpl)
 	if err != nil {
-		panic(err)
+		t.Fatal(err)
 	}
 	_, err = responses.New("repo_no_match").Parse(repoNoMatchTmpl)
 	if err != nil {
-		panic(err)
+		t.Fatal(err)
 	}
 
 	mux := http.NewServeMux()
@@ -206,14 +206,14 @@ func (l localRoundTripper) RoundTrip(req *http.Request) (*http.Response, error)
 func mustRead(r io.Reader) string {
 	b, err := io.ReadAll(r)
 	if err != nil {
-		panic(err)
+		panic(err) // lintignore:R009
 	}
 	return string(b)
 }
 
 func mustWrite(w io.Writer, s string) {
 	_, err := io.WriteString(w, s)
 	if err != nil {
-		panic(err)
+		panic(err) // lintignore:R009
 	}
 }