11package github
22
33import (
4+ "fmt"
45 "net/http"
6+ "net/url"
57 "strconv"
68 "testing"
79
810 "github.com/google/go-cmp/cmp"
911 "github.com/google/go-github/v82/github"
1012 "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
11-
12- "github.com/migueleliasweb/go-github-mock/src/mock"
1313)
1414
1515type (
@@ -41,30 +41,38 @@ func testResourceGithubEMUGroupMappingInstanceStateDataV1(t *testing.T) map[stri
4141 return v0
4242}
4343
44- func buildMockClientForMigrationV0toV1 () * http.Client {
45- return mock .NewMockedHTTPClient (
46- mock .WithRequestMatch (
47- mock .GetOrgsTeamsExternalGroupsByOrgByTeamSlug ,
48- github.ExternalGroupList {
49- Groups : []* github.ExternalGroup {
50- {
51- GroupID : github .Ptr (int64 (testGroupID )),
52- Teams : []* github.ExternalGroupTeam {
53- {
54- TeamID : github .Ptr (int64 (testTeamID )),
55- },
56- },
57- },
58- },
44+ func buildMockResponsesForMigrationV0toV1 () []* mockResponse {
45+ return []* mockResponse {
46+ {
47+ ExpectedUri : fmt .Sprintf ("/orgs/%s/teams/%s/external-groups" , "test-org" , "test-team" ),
48+ ExpectedHeaders : map [string ]string {
49+ "Accept" : "application/vnd.github.v3+json" ,
5950 },
60- ),
61- mock .WithRequestMatch (
62- mock .GetOrgsTeamsByOrgByTeamSlug ,
63- github.Team {
64- ID : github .Ptr (int64 (testTeamID )),
51+ ResponseBody : fmt .Sprintf (`
52+ {
53+ "groups": [
54+ {
55+ "group_id": %d,
56+ "group_name": "test-group",
57+ "updated_at": "2021-01-24T11:31:04-06:00"
58+ }
59+ ]
60+ }` , int64 (testGroupID )),
61+ StatusCode : 201 ,
62+ },
63+ {
64+ ExpectedUri : fmt .Sprintf ("/orgs/%s/teams/%s" , "test-org" , "test-team" ),
65+ ExpectedHeaders : map [string ]string {
66+ "Accept" : "application/vnd.github.v3+json" ,
6567 },
66- ),
67- )
68+ ResponseBody : fmt .Sprintf (`
69+ {
70+ "id": %d
71+ }
72+ ` , testTeamID ),
73+ StatusCode : 200 ,
74+ },
75+ }
6876}
6977
7078func TestGithub_MigrateEMUGroupMappingsState (t * testing.T ) {
@@ -75,27 +83,35 @@ func TestGithub_MigrateEMUGroupMappingsState(t *testing.T) {
7583 }
7684
7785 for _ , d := range []struct {
78- testName string
79- migrationFunc schema.StateUpgradeFunc
80- rawState currentStateFunc
81- want expectedStateFunc
82- buildClient func () * http. Client
83- shouldError bool
86+ testName string
87+ migrationFunc schema.StateUpgradeFunc
88+ rawState currentStateFunc
89+ want expectedStateFunc
90+ buildMockResponses func () [] * mockResponse
91+ shouldError bool
8492 }{
8593 {
86- testName : "migrates v0 to v1" ,
87- migrationFunc : resourceGithubEMUGroupMappingInstanceStateUpgradeV0 ,
88- rawState : testResourceGithubEMUGroupMappingInstanceStateDataV0 ,
89- want : testResourceGithubEMUGroupMappingInstanceStateDataV1 ,
90- buildClient : buildMockClientForMigrationV0toV1 ,
91- shouldError : false ,
94+ testName : "migrates v0 to v1" ,
95+ migrationFunc : resourceGithubEMUGroupMappingInstanceStateUpgradeV0 ,
96+ rawState : testResourceGithubEMUGroupMappingInstanceStateDataV0 ,
97+ want : testResourceGithubEMUGroupMappingInstanceStateDataV1 ,
98+ buildMockResponses : buildMockResponsesForMigrationV0toV1 ,
99+ shouldError : false ,
92100 },
93101 } {
94102 t .Run (d .testName , func (t * testing.T ) {
95103 t .Parallel ()
96104
97- ghClient := github .NewClient (d .buildClient ())
98- meta .v3client = ghClient
105+ ts := githubApiMock (d .buildMockResponses ())
106+ defer ts .Close ()
107+
108+ httpCl := http .DefaultClient
109+ httpCl .Transport = http .DefaultTransport
110+
111+ client := github .NewClient (httpCl )
112+ u , _ := url .Parse (ts .URL + "/" )
113+ client .BaseURL = u
114+ meta .v3client = client
99115
100116 currentState := d .rawState ()
101117 got , err := d .migrationFunc (t .Context (), currentState , meta )
0 commit comments