fix: Repository Custom Properties Refresh (#2691)

SharpEdgeMarshall · nickfloyd · web-flow · commit 36bf7c971451 · 2025-11-12T16:22:10.000-06:00
Co-authored-by: Nick Floyd &lt;139819+nickfloyd@users.noreply.github.com&gt;
diff --git a/github/resource_github_repository_custom_property.go b/github/resource_github_repository_custom_property.go
@@ -109,6 +109,11 @@ func resourceGithubRepositoryCustomPropertyRead(d *schema.ResourceData, meta int
 		return err
 	}
 
+	if wantedCustomPropertyValue == nil {
+		d.SetId("")
+		return nil
+	}
+
 	d.SetId(buildThreePartID(owner, repoName, propertyName))
 	d.Set("repository", repoName)
 	d.Set("property_name", propertyName)
@@ -154,7 +159,7 @@ func readRepositoryCustomPropertyValue(ctx context.Context, client *github.Clien
 	}
 
 	if wantedCustomProperty == nil {
-		return nil, fmt.Errorf("could not find a custom property with name: %s", propertyName)
+		return nil, nil
 	}
 
 	wantedPropertyValue, err := parseRepositoryCustomPropertyValueToStringSlice(wantedCustomProperty)

Original file line number	Diff line number	Diff line change
`@@ -109,6 +109,11 @@ func resourceGithubRepositoryCustomPropertyRead(d *schema.ResourceData, meta int`
`109`	`109`	`return err`
`110`	`110`	`}`
`111`	`111`
	`112`	`+ if wantedCustomPropertyValue == nil {`
	`113`	`+ d.SetId("")`
	`114`	`+ return nil`
	`115`	`+ }`
	`116`	`+`
`112`	`117`	`d.SetId(buildThreePartID(owner, repoName, propertyName))`
`113`	`118`	`d.Set("repository", repoName)`
`114`	`119`	`d.Set("property_name", propertyName)`
`@@ -154,7 +159,7 @@ func readRepositoryCustomPropertyValue(ctx context.Context, client *github.Clien`
`154`	`159`	`}`
`155`	`160`
`156`	`161`	`if wantedCustomProperty == nil {`
`157`		`- return nil, fmt.Errorf("could not find a custom property with name: %s", propertyName)`
	`162`	`+ return nil, nil`
`158`	`163`	`}`
`159`	`164`
`160`	`165`	`wantedPropertyValue, err := parseRepositoryCustomPropertyValueToStringSlice(wantedCustomProperty)`