Inline repoReq.Topics

deiga · deiga · commit 30ed68d2e9a9 · 2026-01-27T22:28:19.000+02:00
Signed-off-by: Timo Sand &lt;timo.sand@f-secure.com&gt;
diff --git a/github/resource_github_repository.go b/github/resource_github_repository.go
@@ -997,10 +997,9 @@ func resourceGithubRepositoryUpdate(ctx context.Context, d *schema.ResourceData,
 	}
 
 	if d.HasChange("topics") {
-		topics := repoReq.Topics
 		// GitHub API docs say that the ReplaceAllTopics endpoint should be used instead of updating the repository with the topics field
 		// https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#update-a-repository
-		_, _, err := client.Repositories.ReplaceAllTopics(ctx, owner, *repo.Name, topics)
+		_, _, err := client.Repositories.ReplaceAllTopics(ctx, owner, repo.GetName(), repoReq.Topics)
 		if err != nil {
 			return diag.FromErr(err)
 		}

Original file line number	Diff line number	Diff line change
`@@ -997,10 +997,9 @@ func resourceGithubRepositoryUpdate(ctx context.Context, d *schema.ResourceData,`
`997`	`997`	`}`
`998`	`998`
`999`	`999`	`if d.HasChange("topics") {`
`1000`		`- topics := repoReq.Topics`
`1001`	`1000`	`// GitHub API docs say that the ReplaceAllTopics endpoint should be used instead of updating the repository with the topics field`
`1002`	`1001`	`// https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#update-a-repository`
`1003`		`- _, _, err := client.Repositories.ReplaceAllTopics(ctx, owner, *repo.Name, topics)`
	`1002`	`+ _, _, err := client.Repositories.ReplaceAllTopics(ctx, owner, repo.GetName(), repoReq.Topics)`
`1004`	`1003`	`if err != nil {`
`1005`	`1004`	`return diag.FromErr(err)`
`1006`	`1005`	`}`