Cleans up multiple calls to the sdk

nickfloyd · AlanCitrix · commit 2945aca21f93 · 2025-12-10T13:35:38.000-05:00
diff --git a/github/resource_github_repository_ruleset.go b/github/resource_github_repository_ruleset.go
@@ -713,13 +713,13 @@ func resourceGithubRepositoryRulesetUpdate(d *schema.ResourceData, meta any) err
 		if err != nil {
 			return err
 		}
-		ruleset, _, err = client.Repositories.UpdateRuleset(ctx, owner, repoName, rulesetID, *rulesetReq)
-	} else {
-		ruleset, _, err = client.Repositories.UpdateRuleset(ctx, owner, repoName, rulesetID, *rulesetReq)
 	}
+
+	ruleset, _, err = client.Repositories.UpdateRuleset(ctx, owner, repoName, rulesetID, *rulesetReq)
 	if err != nil {
 		return err
 	}
+
 	d.SetId(strconv.FormatInt(*ruleset.ID, 10))
 
 	return resourceGithubRepositoryRulesetRead(d, meta)

Original file line number	Diff line number	Diff line change
`@@ -713,13 +713,13 @@ func resourceGithubRepositoryRulesetUpdate(d *schema.ResourceData, meta any) err`
`713`	`713`	`if err != nil {`
`714`	`714`	`return err`
`715`	`715`	`}`
`716`		`- ruleset, _, err = client.Repositories.UpdateRuleset(ctx, owner, repoName, rulesetID, *rulesetReq)`
`717`		`- } else {`
`718`		`- ruleset, _, err = client.Repositories.UpdateRuleset(ctx, owner, repoName, rulesetID, *rulesetReq)`
`719`	`716`	`}`
	`717`	`+`
	`718`	`+ ruleset, _, err = client.Repositories.UpdateRuleset(ctx, owner, repoName, rulesetID, *rulesetReq)`
`720`	`719`	`if err != nil {`
`721`	`720`	`return err`
`722`	`721`	`}`
	`722`	`+`
`723`	`723`	`d.SetId(strconv.FormatInt(*ruleset.ID, 10))`
`724`	`724`
`725`	`725`	`return resourceGithubRepositoryRulesetRead(d, meta)`