[MAINT] enable nilnesserr linter (#3113)

deiga · web-flow · commit 19e9e8327e0f · 2026-02-02T17:10:37.000Z
* Fix returning wrong `err`

Signed-off-by: Timo Sand &lt;timo.sand@f-secure.com&gt;

* Add link to description of `nilnesserr` linter

Signed-off-by: Timo Sand &lt;timo.sand@f-secure.com&gt;

* Revert formatting changes

---------

Signed-off-by: Timo Sand &lt;timo.sand@f-secure.com&gt;
diff --git a/.golangci.yml b/.golangci.yml
@@ -19,6 +19,7 @@ linters:
     - misspell
     - modernize
     - nilerr
+    - nilnesserr # https://golangci-lint.run/docs/linters/configuration/#nilnesserr
     - predeclared
     - staticcheck
     - unconvert
diff --git a/github/resource_github_team_repository.go b/github/resource_github_team_repository.go
@@ -138,7 +138,7 @@ func resourceGithubTeamRepositoryRead(d *schema.ResourceData, meta any) error {
 				return nil
 			}
 		}
-		return err
+		return repoErr
 	}
 
 	if err = d.Set("etag", resp.Header.Get("ETag")); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ func resourceGithubTeamRepositoryRead(d *schema.ResourceData, meta any) error {`
`138`	`138`	`return nil`
`139`	`139`	`}`
`140`	`140`	`}`
`141`		`- return err`
	`141`	`+ return repoErr`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`if err = d.Set("etag", resp.Header.Get("ETag")); err != nil {`