Skip to content

Commit 68cd7c8

Browse files
committed
Remove frame border prop
1 parent 4632c6a commit 68cd7c8

4 files changed

Lines changed: 5 additions & 23 deletions

File tree

IFrameVirtualPCF/ControlManifest.Input.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<manifest>
3-
<control namespace="ReactVirtual" constructor="IFrameVirtualPCF" version="0.0.1" display-name-key="IFrameVirtualPCF (0.0.1)" description-key="IFrameVirtualPCF description" control-type="virtual">
3+
<control namespace="ReactVirtual" constructor="IFrameVirtualPCF" version="0.0.3" display-name-key="IFrameVirtualPCF (0.0.3)" description-key="IFrameVirtualPCF description" control-type="virtual">
44
<!--external-service-usage node declares whether this 3rd party PCF control is using external service or not, if yes, this control will be considered as premium and please also add the external domain it is using.
55
If it is not using any external service, please set the enabled="false" and DO NOT add any domain below. The "enabled" will be false by default.
66
Example1:

IFrameVirtualPCF/components/IFrameControl.tsx

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,8 @@ import * as React from "react";
33
import { IFrameControlProps } from "./Component.types";
44

55
export const IFrameControl = React.memo((props: IFrameControlProps) => {
6-
const {
7-
src,
8-
frameBorder,
9-
width,
10-
height,
11-
onFullScreen,
12-
isFullScreen,
13-
showFullScreenBtn,
14-
} = props;
6+
const { src, width, height, onFullScreen, isFullScreen, showFullScreenBtn } =
7+
props;
158

169
const containerSize = React.useMemo(() => {
1710
return {
@@ -34,12 +27,7 @@ export const IFrameControl = React.memo((props: IFrameControlProps) => {
3427
grow
3528
style={{ position: "relative", backgroundColor: "white" }}
3629
>
37-
<iframe
38-
src={src}
39-
frameBorder={frameBorder}
40-
width={width}
41-
height={height}
42-
></iframe>
30+
<iframe src={src} width={width} height={height}></iframe>
4331
</Stack.Item>
4432
</Stack>
4533
<Stack>

IFrameVirtualPCF/index.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,6 @@ export class IFrameVirtualPCF
1010
private context: ComponentFramework.Context<IInputs>;
1111
isFullScreen = false;
1212

13-
/**
14-
* Empty constructor.
15-
*/
16-
constructor() {}
17-
1813
onFullScreen = (): void => {
1914
this.context.mode.setFullScreen(true);
2015
};
@@ -76,7 +71,6 @@ export class IFrameVirtualPCF
7671

7772
return {
7873
src: undefinedIfEmpty(context.parameters.src),
79-
frameBorder: "0",
8074
width: allocatedWidth,
8175
height: allocatedHeight,
8276
isFullScreen: this.isFullScreen,

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "pcf-project",
3-
"version": "1.0.0",
3+
"version": "1.0.3",
44
"description": "Project containing your PowerApps Component Framework (PCF) control.",
55
"scripts": {
66
"build": "pcf-scripts build",

0 commit comments

Comments
 (0)