fix boolean assignment

Author: iamdual

src/config.ts

@@ -123,10 +123,9 @@ export default class Config {
           }
           break;
         case "landscape":
-          if (
-            typeof params[param] === "string" ||
-            typeof params[param] === "boolean"
-          ) {
+          if (typeof params[param] === "string") {
+            this.landscape = ["true", "1"].includes(params[param]);
+          } else if (typeof params[param] === "boolean") {
             this.landscape = params[param];
           }
           break;
@@ -150,10 +149,9 @@ export default class Config {
           }
           break;
         case "base64":
-          if (
-            typeof params[param] === "string" ||
-            typeof params[param] === "boolean"
-          ) {
+          if (typeof params[param] === "string") {
+            this.base64 = ["true", "1"].includes(params[param]);
+          } else if (typeof params[param] === "boolean") {
             this.base64 = params[param];
           }
           break;

test/config.boolean.test.ts

@@ -0,0 +1,37 @@
+import assert from "assert";
+import Config from "../src/config";
+
+describe("Boolean parameters", function () {
+  describe("javascript", function () {
+    it("Passing a boolean", function () {
+      const config = new Config({ javascript: true });
+      assert.equal(config.javascript, true);
+    });
+    it("Passing a string", function () {
+      const config = new Config({ javascript: "true" });
+      assert.equal(config.javascript, true);
+    });
+  });
+
+  describe("landscape", function () {
+    it("Passing a boolean", function () {
+      const config = new Config({ landscape: true });
+      assert.equal(config.landscape, true);
+    });
+    it("Passing a string", function () {
+      const config = new Config({ landscape: "true" });
+      assert.equal(config.landscape, true);
+    });
+  });
+
+  describe("base64", function () {
+    it("Passing a boolean", function () {
+      const config = new Config({ base64: true });
+      assert.equal(config.base64, true);
+    });
+    it("Passing a string", function () {
+      const config = new Config({ base64: "true" });
+      assert.equal(config.base64, true);
+    });
+  });
+});

test/config.others.test.ts

@@ -24,17 +24,6 @@ describe("Others", function () {
     });
   });
 
-  describe("javascript", function () {
-    it("Passing a boolean", function () {
-      const config = new Config({ javascript: true });
-      assert.equal(config.javascript, true);
-    });
-    it("Passing a string", function () {
-      const config = new Config({ javascript: "true" });
-      assert.equal(config.javascript, true);
-    });
-  });
-
   describe("format", function () {
     it("Should accept lowercase", function () {
       const config = new Config({ format: "tabloid" });