Skip to content

Commit 8fe1b9f

Browse files
committed
[FIXED] Most of the lint errors from CI
``` /Users/hossain/dev/repos/hk-projects/hossainkhan.com/index.html 22:11 error Attribute "href" used ' instead of expected " attr-quotes 22:91 error Attribute "rel" used ' instead of expected " attr-quotes 22:108 error Attribute "type" used ' instead of expected " attr-quotes 23:11 error Attribute "href" used ' instead of expected " attr-quotes 23:77 error Attribute "rel" used ' instead of expected " attr-quotes 23:94 error Attribute "type" used ' instead of expected " attr-quotes 58:155 error Expected omitted end tag <img> instead of self-closing element <img/> void-style 77:98 error Expected omitted end tag <input> instead of self-closing element <input/> void-style 113:197 error Expected omitted end tag <img> instead of self-closing element <img/> void-style 183:49 error Expected omitted end tag <hr> instead of self-closing element <hr/> void-style 684:26 error Element <p> is implicitly closed by parent </div> no-implicit-close 690:26 error Element <p> is implicitly closed by parent </div> no-implicit-close 701:18 error Landmarks must have a non-empty and unique accessible name (aria-label or aria-labelledby) unique-landmark 716:18 error Landmarks must have a non-empty and unique accessible name (aria-label or aria-labelledby) unique-landmark 732:83 error Prefer to use the native <progress> element prefer-native-element 732:102 error Inline style is not allowed no-inline-style 742:83 error Prefer to use the native <progress> element prefer-native-element 742:102 error Inline style is not allowed no-inline-style 755:83 error Prefer to use the native <progress> element prefer-native-element 755:102 error Inline style is not allowed no-inline-style 767:83 error Prefer to use the native <progress> element prefer-native-element 767:102 error Inline style is not allowed no-inline-style 778:83 error Prefer to use the native <progress> element prefer-native-element 778:102 error Inline style is not allowed no-inline-style 789:83 error Prefer to use the native <progress> element prefer-native-element 789:102 error Inline style is not allowed no-inline-style 800:83 error Prefer to use the native <progress> element prefer-native-element 800:102 error Inline style is not allowed no-inline-style 811:83 error Prefer to use the native <progress> element prefer-native-element 811:102 error Inline style is not allowed no-inline-style 821:18 error Landmarks must have a non-empty and unique accessible name (aria-label or aria-labelledby) unique-landmark 902:94 error Expected omitted end tag <br> instead of self-closing element <br/> void-style 906:115 error Expected omitted end tag <br> instead of self-closing element <br/> void-style 995:13 error "type" attribute is unnecessary for javascript resources script-type 996:13 error "type" attribute is unnecessary for javascript resources script-type 997:13 error "type" attribute is unnecessary for javascript resources script-type 998:13 error "type" attribute is unnecessary for javascript resources script-type 1000:13 error "type" attribute is unnecessary for javascript resources script-type 1002:13 error "type" attribute is unnecessary for javascript resources script-type 1003:13 error "type" attribute is unnecessary for javascript resources script-type 1005:13 error "type" attribute is unnecessary for javascript resources script-type ✖ 41 problems (41 errors, 0 warnings) More information: https://html-validate.org/rules/attr-quotes.html https://html-validate.org/rules/void-style.html https://html-validate.org/rules/no-implicit-close.html https://html-validate.org/rules/unique-landmark.html https://html-validate.org/rules/prefer-native-element.html https://html-validate.org/rules/no-inline-style.html https://html-validate.org/rules/script-type.html ```
1 parent 7290771 commit 8fe1b9f

1 file changed

Lines changed: 20 additions & 22 deletions

File tree

index.html

Lines changed: 20 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
<link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png">
2020
<link rel="manifest" href="/site.webmanifest">
2121

22-
<link href='https://fonts.googleapis.com/css?family=Lato:300,400,300italic,400italic' rel='stylesheet' type='text/css'>
23-
<link href='https://fonts.googleapis.com/css?family=Montserrat:400,700' rel='stylesheet' type='text/css'>
22+
<link href="https://fonts.googleapis.com/css?family=Lato:300,400,300italic,400italic" rel="stylesheet" type="text/css">
23+
<link href="https://fonts.googleapis.com/css?family=Montserrat:400,700" rel="stylesheet" type="text/css">
2424

2525
<!-- FontAwesome JS -->
2626
<script defer src="assets/fontawesome/js/all.js"></script>
@@ -55,7 +55,7 @@
5555
<div class="container">
5656
<div class="row align-items-center">
5757
<div class="col">
58-
<img class="profile-image img-fluid float-start rounded-circle" src="assets/images/profile_cartoon.png" alt="Hossain Khan - Portrait" />
58+
<img class="profile-image img-fluid float-start rounded-circle" src="assets/images/profile_cartoon.png" alt="Hossain Khan - Portrait">
5959
<div class="profile-content">
6060
<h1 class="name">Hossain Khan</h1>
6161
<h2 class="desc">Software Engineer</h2>
@@ -74,7 +74,7 @@ <h2 class="desc">Software Engineer</h2>
7474
<div class="col-12 col-md-auto">
7575
<div class="dark-mode-switch d-flex">
7676
<div class="form-check form-switch mx-auto mx-md-0">
77-
<input type="checkbox" class="form-check-input me-2" id="darkSwitch" />
77+
<input type="checkbox" class="form-check-input me-2" id="darkSwitch">
7878
<label class="custom-control-label" for="darkSwitch">Dark Mode</label>
7979
</div>
8080
</div><!--//dark-mode-switch-->
@@ -110,7 +110,7 @@ <h3 class="title mb-3"><a href="https://github.com/hossain-khan/android-keep-ali
110110
<p class="summary">A simple app to keep specific apps alive by checking if they are running. If not, they will be started for you.</p>
111111
<div class="featured-image has-ribbon">
112112
<a href="https://github.com/hossain-khan/android-keep-alive" target="_blank">
113-
<img class="img-fluid project-image rounded shadow-sm" src="assets/images/projects/keep-alive-banner-art.png" alt="Android Keep Alive Project Banner Image" />
113+
<img class="img-fluid project-image rounded shadow-sm" src="assets/images/projects/keep-alive-banner-art.png" alt="Android Keep Alive Project Banner Image">
114114
</a>
115115
<div class="ribbon">
116116
<div class="text">Alpha</div>
@@ -180,7 +180,7 @@ <h3 class="title mb-3"><a href="https://play.google.com/store/apps/details?id=co
180180

181181

182182
<!-- ========================================================================= -->
183-
<hr class="divider" /><!-- divider between featured and non-featured items -->
183+
<hr class="divider"><!-- divider between featured and non-featured items -->
184184
<!-- ========================================================================= -->
185185

186186
<!-- Non feature item (smaller size) -->
@@ -680,15 +680,13 @@ <h6>Key Accomplishments</h6>
680680

681681
<section class="github section">
682682
<div class="section-inner shadow-sm rounded">
683-
<h2 class="heading">My GitHub</h2>
684-
<p>You can embed your GitHub contribution graph calendar using IonicaBizau's <a href="https://github.com/hossain-khan" target="_blank">GitHub Calendar</a> widget.
683+
<h2 class="heading">My GitHub Feed</h2>
685684

686685
<div id="github-graph" class="github-graph">
687686

688687
</div><!--//github-graph-->
689688

690-
<p>You can also embed your GitHub activities using Casey Scarborough's <a href="https://github.com/hossain-khan/github-activity" target="_blank">GitHub Activity Stream</a> widget.
691-
<!--//Usage: https://caseyscarborough.com/projects/github-activity/ -->
689+
<!--//Usage: https://caseyscarborough.com/projects/github-activity/ -->
692690
<div id="ghfeed" class="ghfeed">
693691
</div><!--//ghfeed-->
694692

@@ -698,7 +696,7 @@ <h2 class="heading">My GitHub</h2>
698696
</div><!--//primary-->
699697

700698
<div class="secondary col-lg-4 col-12">
701-
<aside class="info aside section">
699+
<aside class="info aside section" aria-label="Contact Information">
702700
<div class="section-inner shadow-sm rounded">
703701
<h2 class="heading sr-only">Basic Information</h2>
704702
<div class="content">
@@ -713,7 +711,7 @@ <h2 class="heading sr-only">Basic Information</h2>
713711
</div><!--//section-inner-->
714712
</aside><!--//aside-->
715713

716-
<aside class="skills aside section">
714+
<aside class="skills aside section" aria-label="Skills">
717715
<div class="section-inner shadow-sm rounded">
718716
<h2 class="heading">Skills</h2>
719717
<div class="content">
@@ -818,7 +816,7 @@ <h3 class="level-title">CI/CD<span
818816
</div><!--//section-inner-->
819817
</aside><!--//section-->
820818

821-
<aside class="testimonials aside section">
819+
<aside class="testimonials aside section" aria-label="Testimonials">
822820
<div class="section-inner shadow-sm rounded">
823821
<h2 class="heading">Testimonials</h2>
824822
<div class="content">
@@ -899,11 +897,11 @@ <h2 class="heading">Languages</h2>
899897
<ul class="list-unstyled">
900898
<li class="item">
901899
<i class="fas fa-language"></i> <span class="title"><strong>Bengali:</strong></span>
902-
<span class="level">Native Speaker <br class="visible-xs"/><i class="fas fa-star"></i> <i class="fas fa-star"></i> <i class="fas fa-star"></i> <i class="fas fa-star"></i> <i class="fas fa-star"></i></span>
900+
<span class="level">Native Speaker <br class="visible-xs"><i class="fas fa-star"></i> <i class="fas fa-star"></i> <i class="fas fa-star"></i> <i class="fas fa-star"></i> <i class="fas fa-star"></i></span>
903901
</li><!--//item-->
904902
<li class="item">
905903
<i class="fas fa-language"></i> <span class="title"><strong>English:</strong></span>
906-
<span class="level">Professional Proficiency <br class="visible-sm visible-xs"/><i class="fas fa-star"></i> <i class="fas fa-star"></i> <i class="fas fa-star"></i> <i class="fas fa-star-half"></i></span>
904+
<span class="level">Professional Proficiency <br class="visible-sm visible-xs"><i class="fas fa-star"></i> <i class="fas fa-star"></i> <i class="fas fa-star"></i> <i class="fas fa-star-half"></i></span>
907905
</li><!--//item-->
908906
</ul>
909907
</div><!--//languages-content-->
@@ -992,15 +990,15 @@ <h2 class="heading">Conferences</h2>
992990
</footer><!--//footer-->
993991

994992
<!-- Javascript -->
995-
<script type="text/javascript" src="assets/plugins/popper.min.js"></script>
996-
<script type="text/javascript" src="assets/plugins/bootstrap/js/bootstrap.min.js"></script>
997-
<script type="text/javascript" src="assets/plugins/vanilla-rss/dist/rss.global.min.js"></script>
998-
<script type="text/javascript" src="assets/plugins/dark-mode-switch/dark-mode-switch.min.js"></script>
993+
<script src="assets/plugins/popper.min.js"></script>
994+
<script src="assets/plugins/bootstrap/js/bootstrap.min.js"></script>
995+
<script src="assets/plugins/vanilla-rss/dist/rss.global.min.js"></script>
996+
<script src="assets/plugins/dark-mode-switch/dark-mode-switch.min.js"></script>
999997
<!-- github calendar plugin -->
1000-
<script type="text/javascript" src="assets/plugins/github-calendar/dist/github-calendar.min.js"></script>
998+
<script src="assets/plugins/github-calendar/dist/github-calendar.min.js"></script>
1001999
<!-- github activity plugin -->
1002-
<script type="text/javascript" src="//cdnjs.cloudflare.com/ajax/libs/mustache.js/0.7.2/mustache.min.js"></script>
1003-
<script type="text/javascript" src="assets/plugins/github-activity/src/github-activity.js"></script>
1000+
<script src="//cdnjs.cloudflare.com/ajax/libs/mustache.js/0.7.2/mustache.min.js"></script>
1001+
<script src="assets/plugins/github-activity/src/github-activity.js"></script>
10041002
<!-- custom js - initializes RSS, GitHub Calendar, Skills and so on -->
10051003
<script type="text/javascript" src="assets/js/main.js"></script>
10061004
</body>

0 commit comments

Comments
 (0)