Merge pull request #3733 from hey-api/copilot/fix-bigint-transformer-output

Author: mrlubos

.changeset/selfish-carrots-serve.md

@@ -0,0 +1,5 @@
+---
+"@hey-api/openapi-ts": patch
+---
+
+**plugin(@hey-api/transformers)**: fix: return value for primitive array entries

packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/transformers-array/transformers.gen.ts

@@ -7,5 +7,7 @@ export const getFooResponseTransformer = async (data: any): Promise<GetFooRespon
         item.baz = new Date(item.baz);
         return item;
     });
+    data.bar = data.bar.map((item: any) => BigInt(item.toString()));
+    data.baz = data.baz.map((item: any) => new Date(item));
     return data;
 };

packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/transformers-array/types.gen.ts

@@ -19,6 +19,8 @@ export type GetFooResponses = {
         foo: Array<{
             baz: Date;
         }>;
+        bar: Array<bigint>;
+        baz: Array<Date>;
     };
 };
 

packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/transformers-array/transformers.gen.ts

@@ -7,5 +7,7 @@ export const getFooResponseTransformer = async (data: any): Promise<GetFooRespon
         item.baz = new Date(item.baz);
         return item;
     });
+    data.bar = data.bar.map((item: any) => BigInt(item.toString()));
+    data.baz = data.baz.map((item: any) => new Date(item));
     return data;
 };

packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/transformers-array/types.gen.ts

@@ -19,6 +19,8 @@ export type GetFooResponses = {
         foo: Array<{
             baz: Date;
         }>;
+        bar: Array<bigint>;
+        baz: Array<Date>;
     };
 };
 

packages/openapi-ts/src/plugins/@hey-api/transformers/expressions.ts

@@ -13,7 +13,7 @@ export const bigIntExpressions: ExpressionTransformer = ({ dataExpression, schem
 
   if (bigIntCallExpression) {
     if (typeof dataExpression === 'string') {
-      return [bigIntCallExpression];
+      return [$.return(bigIntCallExpression)];
     }
 
     if (dataExpression) {
@@ -30,7 +30,7 @@ export const dateExpressions: ExpressionTransformer = ({ dataExpression, schema
   }
 
   if (typeof dataExpression === 'string') {
-    return [$.new('Date').arg(dataExpression)];
+    return [$.return($.new('Date').arg(dataExpression))];
   }
 
   if (dataExpression) {

packages/openapi-ts/src/plugins/@hey-api/transformers/types.ts

@@ -15,7 +15,7 @@ export type ExpressionTransformer = (
     config: Omit<UserConfig, 'name'>;
     dataExpression?: ts.Expression | ReturnType<typeof $.attr | typeof $.expr> | string;
   },
-) => Array<TsDsl<ts.Expression>> | undefined;
+) => Array<TsDsl<ts.Expression> | ReturnType<typeof $.return>> | undefined;
 
 /**
  * Returns the TypeScript type node for a schema with a specific format.

specs/3.0.x/transformers-array.json

@@ -27,9 +27,23 @@
                         },
                         "required": ["baz"]
                       }
+                    },
+                    "bar": {
+                      "type": "array",
+                      "items": {
+                        "type": "integer",
+                        "format": "int64"
+                      }
+                    },
+                    "baz": {
+                      "type": "array",
+                      "items": {
+                        "type": "string",
+                        "format": "date-time"
+                      }
                     }
                   },
-                  "required": ["foo"]
+                  "required": ["foo", "bar", "baz"]
                 }
               }
             }

specs/3.1.x/transformers-array.json

@@ -27,9 +27,23 @@
                         },
                         "required": ["baz"]
                       }
+                    },
+                    "bar": {
+                      "type": "array",
+                      "items": {
+                        "type": "integer",
+                        "format": "int64"
+                      }
+                    },
+                    "baz": {
+                      "type": "array",
+                      "items": {
+                        "type": "string",
+                        "format": "date-time"
+                      }
                     }
                   },
-                  "required": ["foo"]
+                  "required": ["foo", "bar", "baz"]
                 }
               }
             }