Skip to content

Commit b02b668

Browse files
committed
changed gains
1 parent e738e17 commit b02b668

3 files changed

Lines changed: 20 additions & 15 deletions

File tree

src/main/java/frc/robot/commands/AimbotStatic.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ public void turnToSpeaker() {
248248
// Called once the command ends or is interrupted.
249249
@Override
250250
public void end(boolean interrupted) {
251-
shooter.setFeedersRPM(2260);
251+
shooter.setFeedersRPM(3538);
252252
led.setState(LED_STATE.GREY);
253253
}
254254

src/main/java/frc/robot/commands/AimbotTele.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ public void turnToSpeaker() {
230230
// Called once the command ends or is interrupted.
231231
@Override
232232
public void end(boolean interrupted) {
233-
shooter.setFeedersRPM(2260);
233+
shooter.setFeedersRPM(3538);
234234
led.setState(LED_STATE.GREY);
235235
}
236236

src/main/java/frc/robot/subsystems/Shooter/Shooter.java

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ public class Shooter extends SubsystemBase {
2828
private final FeederIOInputsAutoLogged feedInputs = new FeederIOInputsAutoLogged();
2929
private final DistanceSensorIOInputsAutoLogged sInputs = new DistanceSensorIOInputsAutoLogged();
3030

31-
private final SimpleMotorFeedforward flywheelFFModel;
31+
private final SimpleMotorFeedforward leftFlywheelFFModel;
32+
private final SimpleMotorFeedforward rightFlywheelFFModel;
3233
private final SimpleMotorFeedforward feederFFModel;
3334

3435
private static final LoggedTunableNumber flywheelkP = new LoggedTunableNumber("flywheelkP");
@@ -43,7 +44,8 @@ public Shooter(
4344
FlywheelIO flywheels, FeederIO feeder, DistanceSensorIO dist, LeafBlowerIO leafBlower) {
4445
switch (Constants.getMode()) {
4546
case REAL:
46-
flywheelFFModel = new SimpleMotorFeedforward(0, 0.25, 0); // make constant
47+
leftFlywheelFFModel = new SimpleMotorFeedforward(0, 0.25, 0); // make constant
48+
rightFlywheelFFModel = new SimpleMotorFeedforward(0.18, 0.3);
4749

4850
feederFFModel = new SimpleMotorFeedforward(0, 0, 0);
4951

@@ -57,13 +59,15 @@ public Shooter(
5759
lastNoteState = NoteState.Init;
5860
break;
5961
case REPLAY:
60-
flywheelFFModel = new SimpleMotorFeedforward(0, 0.03);
62+
leftFlywheelFFModel = new SimpleMotorFeedforward(0, 0.03);
63+
rightFlywheelFFModel = new SimpleMotorFeedforward(0.18, 0.3);
6164
feederFFModel = new SimpleMotorFeedforward(0, 0.03);
6265
break;
6366
case SIM:
64-
flywheelFFModel = new SimpleMotorFeedforward(0, 0.5);
67+
leftFlywheelFFModel = new SimpleMotorFeedforward(0, 0.5);
68+
rightFlywheelFFModel = new SimpleMotorFeedforward(0.18, 0.3);
6569

66-
feederFFModel = new SimpleMotorFeedforward(0, 0.5);
70+
feederFFModel = new SimpleMotorFeedforward(0, 0.58);
6771

6872
flywheelkP.initDefault(0.4); // make constant
6973
flywheelkI.initDefault(0);
@@ -74,7 +78,8 @@ public Shooter(
7478
feederkD.initDefault(0);
7579
break;
7680
default:
77-
flywheelFFModel = new SimpleMotorFeedforward(0, 0.03);
81+
leftFlywheelFFModel = new SimpleMotorFeedforward(0, 0.03);
82+
rightFlywheelFFModel = new SimpleMotorFeedforward(0.18, 0.3);
7883
feederFFModel = new SimpleMotorFeedforward(0, 0.03);
7984
break;
8085
}
@@ -102,31 +107,31 @@ public void setFeedersRPM(double velocityRPM) {
102107

103108
public void setFlywheelRPMs(double leftVelocityRPM, double rightVelocityRPM) {
104109

105-
ff = flywheelFFModel.calculate(rightVelocityRPM / 60.);
110+
ff = leftFlywheelFFModel.calculate(rightVelocityRPM / 60.);
106111
flywheels.setVelocityRPS(
107112
leftVelocityRPM / 60.,
108113
rightVelocityRPM / 60.,
109-
flywheelFFModel.calculate(leftVelocityRPM / 60.),
110-
flywheelFFModel.calculate(rightVelocityRPM / 60.));
114+
leftFlywheelFFModel.calculate(leftVelocityRPM / 60.),
115+
rightFlywheelFFModel.calculate(rightVelocityRPM / 60.));
111116
}
112117

113118
public void setFlywheelRPMSSource() {
114119
if (DriverStation.getAlliance().get() == Alliance.Blue) {
115120
flywheels.setVelocityRPS(
116-
5000, 4200, flywheelFFModel.calculate(5000 / 60.), flywheelFFModel.calculate(4200 / 60.));
121+
5000, 4200, leftFlywheelFFModel.calculate(5000 / 60.), leftFlywheelFFModel.calculate(4200 / 60.));
117122
} else {
118123
flywheels.setVelocityRPS(
119-
4200, 5000, flywheelFFModel.calculate(5000 / 60.), flywheelFFModel.calculate(4200 / 60.));
124+
4200, 5000, leftFlywheelFFModel.calculate(5000 / 60.), leftFlywheelFFModel.calculate(4200 / 60.));
120125
}
121126
}
122127

123128
public void setFlywheelRPMSAmp() {
124129
if (DriverStation.getAlliance().get() == Alliance.Blue) {
125130
flywheels.setVelocityRPS(
126-
4200, 5000, flywheelFFModel.calculate(4200 / 60.), flywheelFFModel.calculate(5000 / 60.));
131+
4200, 5000, leftFlywheelFFModel.calculate(4200 / 60.), leftFlywheelFFModel.calculate(5000 / 60.));
127132
} else {
128133
flywheels.setVelocityRPS(
129-
5000, 4200, flywheelFFModel.calculate(5000 / 60.), flywheelFFModel.calculate(4200 / 60.));
134+
5000, 4200, leftFlywheelFFModel.calculate(5000 / 60.), leftFlywheelFFModel.calculate(4200 / 60.));
130135
}
131136
}
132137

0 commit comments

Comments
 (0)