Change notification and log messages for clarity

Author: thyeggman

src/git/repository.ts

@@ -6,7 +6,7 @@ import {getRemoteName} from "../configuration/configuration";
 import {Protocol} from "../external/protocol";
 import {logDebug, logError} from "../log";
 import {API, GitExtension, RefType, RepositoryState} from "../typings/git";
-import {hasInternetConnectivity} from "../util";
+import {hasInternetConnectivity as canReachGitHubAPI} from "../util";
 
 interface GitHubUrls {
   workspaceUri: vscode.Uri;
@@ -143,7 +143,7 @@ export async function getGitHubContext(): Promise<GitHubContext | undefined> {
     return gitHubContext;
   }
 
-  if (!(await hasInternetConnectivity())) {
+  if (!(await canReachGitHubAPI())) {
     logError(new Error("Cannot fetch github context"));
     return undefined;
   }

src/treeViews/currentBranch.ts

@@ -47,7 +47,7 @@ export class CurrentBranchTreeProvider
     if (await hasInternetConnectivity()) {
       this._onDidChangeTreeData.fire(null);
     } else {
-      await vscode.window.showWarningMessage("Unable to refresh, you are not connected to the internet");
+      await vscode.window.showWarningMessage("Unable to refresh, could not reach GitHub API");
     }
   }
 

src/treeViews/settings.ts

@@ -26,7 +26,7 @@ export class SettingsTreeProvider implements vscode.TreeDataProvider<SettingsExp
     if (await hasInternetConnectivity()) {
       this._onDidChangeTreeData.fire(null);
     } else {
-      await vscode.window.showWarningMessage("Unable to refresh, you are not connected to the internet");
+      await vscode.window.showWarningMessage("Unable to refresh, could not reach GitHub API");
     }
   }
 

src/treeViews/workflows.ts

@@ -50,7 +50,7 @@ export class WorkflowsTreeProvider
     if (await hasInternetConnectivity()) {
       this._onDidChangeTreeData.fire(null);
     } else {
-      await vscode.window.showWarningMessage("Unable to refresh, you are not connected to the internet");
+      await vscode.window.showWarningMessage("Unable to refresh, could not reach GitHub API");
     }
   }
 

src/util.ts

@@ -11,7 +11,7 @@ export async function hasInternetConnectivity() {
       }
     });
   } catch {
-    logError(new Error("Unable to connect to the internet"));
+    logError(new Error("Unable to connect to GitHub API"));
     return false;
   }
   return true;