Skip to content

Commit b3c8678

Browse files
author
Crystal Tenn
committed
Fix typescript errors and make log tooltips more specific
1 parent dcfe90a commit b3c8678

2 files changed

Lines changed: 4 additions & 9 deletions

File tree

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@
140140
{
141141
"command": "github-actions.workflow.logs",
142142
"category": "GitHub Actions",
143-
"title": "View logs",
143+
"title": "View job logs",
144144
"when": "viewItem =~ /job/",
145145
"icon": {
146146
"dark": "resources/icons/dark/logs.svg",
@@ -150,7 +150,7 @@
150150
{
151151
"command": "github-actions.step.logs",
152152
"category": "GitHub Actions",
153-
"title": "View logs",
153+
"title": "View step logs",
154154
"when": "viewItem =~ /step/",
155155
"icon": "$(globe)"
156156
},

src/commands/openWorkflowStepLogs.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
import * as vscode from "vscode";
2-
import {WorkflowJob, WorkflowStep} from "../model";
2+
import {WorkflowStepNode} from "../treeViews/workflows/workflowStepNode";
33

4-
export interface WorkflowStepCommandArgs {
5-
job: WorkflowJob;
6-
step: WorkflowStep;
7-
}
8-
9-
// export type WorkflowStepCommandArgs = Pick<WorkflowJobNode, "job">;
4+
type WorkflowStepCommandArgs = Pick<WorkflowStepNode, "job" | "step" | "gitHubRepoContext">;
105

116
export function registerOpenWorkflowStepLogs(context: vscode.ExtensionContext) {
127
context.subscriptions.push(

0 commit comments

Comments
 (0)