Merge pull request #122 from github/joshmgross/lint

Run formatting, linting, and tests in CI

Author: joshmgross

.eslintrc.json

@@ -9,17 +9,13 @@
     "plugin:@typescript-eslint/recommended-requiring-type-checking",
     "prettier"
   ],
+  "ignorePatterns": ["src/external"],
   "parser": "@typescript-eslint/parser",
   "parserOptions": {
     "project": "./tsconfig.json"
   },
   "plugins": ["@typescript-eslint", "prettier"],
   "reportUnusedDisableDirectives": true,
   "root": true,
-  "rules": {
-    "no-control-regex": "off",
-    "@typescript-eslint/ban-ts-comment": "off",
-    "@typescript-eslint/no-inferrable-types": ["warn", {"ignoreParameters": true, "ignoreProperties": true}],
-    "@typescript-eslint/triple-slash-reference": "off"
-  }
+  "rules": {}
 }

.github/workflows/build.yml

@@ -19,7 +19,10 @@ jobs:
       - run: npm ci
         env:
           NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - run: npm run format-check
+      - run: npm run lint
       - name: build
-        run: npm run build --if-present
+        run: npm run build
         env:
           CI: true
+      - run: npm run test

package-lock.json

@@ -510,8 +510,8 @@
     "open-in-browser": "vscode-test-web --extensionDevelopmentPath=. .",
     "lint": "eslint . --ext .ts",
     "lint-fix": "eslint . --ext .ts --fix",
-    "prettier": "prettier .",
-    "prettier-fix": "prettier --write .",
+    "format": "prettier --write '**/*.ts'",
+    "format-check": "prettier --check '**/*.ts'",
     "test": "NODE_OPTIONS=\"--experimental-vm-modules\" jest",
     "test-watch": "NODE_OPTIONS=\"--experimental-vm-modules\" jest --watch"
   },
@@ -528,7 +528,7 @@
     "eslint-plugin-prettier": "^4.2.1",
     "jest": "^29.0.3",
     "node-loader": "^0.6.0",
-    "prettier": "^2.7.1",
+    "prettier": "^2.8.3",
     "rimraf": "^3.0.1",
     "source-map-loader": "^4.0.1",
     "ts-jest": "^29.0.3",

package.json

@@ -1,7 +1,6 @@
 import {Octokit} from "@octokit/rest";
 import {version} from "../../package.json";
 
-// eslint-disable-next-line @typescript-eslint/restrict-template-expressions
 export const userAgent = `VS Code GitHub Actions (${version})`;
 
 export function getClient(token: string): Octokit {

src/api/api.ts

@@ -3,7 +3,6 @@ import {GitHubRepoContext} from "../git/repository";
 import {updateDecorations} from "../logs/formatProvider";
 import {getLogInfo} from "../logs/logInfo";
 import {buildLogURI} from "../logs/scheme";
-import {WorkflowStep} from "../model";
 import {WorkflowJob} from "../store/WorkflowJob";
 
 export interface OpenWorkflowJobLogsCommandArgs {

src/commands/openWorkflowJobLogs.ts

@@ -1 +1,2 @@
-declare var PRODUCTION: boolean;
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
+declare let PRODUCTION: boolean;

src/globals.ts

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-control-regex
 const ansiColorRegex = /\u001b\[(\d+;?)+m/gm;
 const groupMarker = "##[group]";
 

src/logs/model.ts

@@ -16,6 +16,7 @@ export const URLRegex = /([{([]*https?:\/\/[a-z0-9]+(?:-[a-z0-9]+)*\.[^\s<>|'",]
  * (?:(?:;[0-9]{0,3})*)?: Match one or more occurances of the format we want with semicolon
  */
 
+// eslint-disable-next-line no-control-regex
 const _ansiEscapeCodeRegex = /(?:\u001b\[)(?:[?|#])?(?:(?:[0-9]{1,3})?(?:(?:;[0-9]{0,3})*)?[A-Z|a-z])/;
 
 /**

src/logs/parser.ts

@@ -10,7 +10,7 @@ dayjs.extend(relativeTime);
 
 // Returns a string like "**Succeeded** in **1m 2s**"
 // For use in markdown tooltip
-export function getStatusString(item: WorkflowRun | WorkflowRunAttempt, capitalize: boolean = false): string {
+export function getStatusString(item: WorkflowRun | WorkflowRunAttempt, capitalize = false): string {
   let statusText = item.run.conclusion || item.run.status || "";
   switch (statusText) {
     case "success":
@@ -70,7 +70,7 @@ export function getEventString(item: WorkflowRun | WorkflowRunAttempt): string {
   }
 
   if (item.run.run_started_at) {
-    let started_at = dayjs(item.run.run_started_at);
+    const started_at = dayjs(item.run.run_started_at);
     eventString += ` ${started_at.fromNow()} *(${started_at.format("LLL")})*`;
   }