Merge pull request #114 from github/joshmgross/error-experience

Improve experience when outside a GitHub repo

Author: joshmgross

package.json

@@ -252,29 +252,40 @@
         {
           "id": "github-actions.current-branch",
           "name": "Current Branch",
-          "when": "github-actions.signed-in"
+          "when": "github-actions.internet-access && github-actions.signed-in && github-actions.has-repos"
         },
         {
           "id": "github-actions.workflows",
           "name": "Workflows",
-          "when": "github-actions.signed-in"
+          "when": "github-actions.internet-access && github-actions.signed-in && github-actions.has-repos"
         },
         {
           "id": "github-actions.settings",
           "name": "Settings",
-          "when": "github-actions.signed-in"
+          "when": "github-actions.internet-access && github-actions.signed-in && github-actions.has-repos"
         },
         {
           "id": "github-actions.empty-view",
           "name": "",
-          "when": "!github-actions.signed-in"
+          "when": "!github-actions.internet-access || !github-actions.signed-in || !github-actions.has-repos"
         }
       ]
     },
     "viewsWelcome": [
       {
         "view": "github-actions.empty-view",
-        "contents": "Sign in to GitHub to display runs, workflows, and configure Actions settings\n[Sign in to GitHub](command:github-actions.sign-in)"
+        "contents": "Unable to connect to the GitHub API, please check your internet connection.\n[Refresh](command:github-actions.explorer.refresh)",
+        "when": "!github-actions.internet-access"
+      },
+      {
+        "view": "github-actions.empty-view",
+        "contents": "Sign in to GitHub to display runs, workflows, and configure Actions settings.\n[Sign in to GitHub](command:github-actions.sign-in)",
+        "when": "github-actions.internet-access && !github-actions.signed-in"
+      },
+      {
+        "view": "github-actions.empty-view",
+        "contents": "No GitHub repositories found. Please open a folder that contains a GitHub repository.",
+        "when": "github-actions.internet-access && github-actions.signed-in && !github-actions.has-repos"
       }
     ],
     "viewsContainers": {

src/extension.ts

@@ -1,5 +1,6 @@
 import * as vscode from "vscode";
 
+import {getSession} from "./auth/auth";
 import {registerCancelWorkflowRun} from "./commands/cancelWorkflowRun";
 import {registerOpenWorkflowFile} from "./commands/openWorkflowFile";
 import {registerOpenWorkflowJobLogs} from "./commands/openWorkflowJobLogs";
@@ -31,17 +32,23 @@ import {initResources} from "./treeViews/icons";
 import {initTreeViews} from "./treeViews/treeViews";
 import {deactivateLanguageServer, initLanguageServer} from "./workflow/languageServer";
 import {registerSignIn} from "./commands/signIn";
+import {canReachGitHubAPI} from "./util";
 
 export async function activate(context: vscode.ExtensionContext) {
   initLogger();
 
   log("Activating GitHub Actions extension...");
 
-  // Set signed-in context before other initializations use the session
-  await vscode.commands.executeCommand("setContext", "github-actions.signed-in", false);
+  const canReachAPI = await canReachGitHubAPI();
+  const hasSession = canReachAPI && !!(await getSession());
 
   // Prefetch git repository origin url
-  await getGitHubContext();
+  const ghContext = hasSession && (await getGitHubContext());
+  const hasGitHubRepos = ghContext && ghContext.repos.length > 0;
+
+  await vscode.commands.executeCommand("setContext", "github-actions.internet-access", canReachAPI);
+  await vscode.commands.executeCommand("setContext", "github-actions.signed-in", hasSession);
+  await vscode.commands.executeCommand("setContext", "github-actions.has-repos", hasGitHubRepos);
 
   initResources(context);
   initConfiguration(context);

src/tracker/workspaceTracker.ts

@@ -6,7 +6,9 @@ export function initWorkspaceChangeTracker(context: vscode.ExtensionContext) {
   const onDidChangeWorkspaceFolders = async (event: vscode.WorkspaceFoldersChangeEvent) => {
     if (event.added.length > 0 || event.removed.length > 0) {
       resetGitHubContext();
-      await getGitHubContext();
+      const context = await getGitHubContext();
+      const hasGitHubRepos = context && context.repos.length > 0;
+      await vscode.commands.executeCommand("setContext", "github-actions.has-repos", hasGitHubRepos);
     }
   };
   context.subscriptions.push(vscode.workspace.onDidChangeWorkspaceFolders(onDidChangeWorkspaceFolders));

src/treeViews/treeViews.ts

@@ -3,6 +3,7 @@ import {executeCacheClearCommand} from "../workflow/languageServer";
 import {getGitHubContext} from "../git/repository";
 import {logDebug} from "../log";
 import {RunStore} from "../store/store";
+import {canReachGitHubAPI} from "../util";
 import {CurrentBranchTreeProvider} from "./currentBranch";
 import {SettingsTreeProvider} from "./settings";
 import {WorkflowsTreeProvider} from "./workflows";
@@ -21,8 +22,12 @@ export async function initTreeViews(context: vscode.ExtensionContext, store: Run
 
   context.subscriptions.push(
     vscode.commands.registerCommand("github-actions.explorer.refresh", async () => {
-      await workflowTreeProvider.refresh();
-      await settingsTreeProvider.refresh();
+      const canReachAPI = await canReachGitHubAPI();
+      await vscode.commands.executeCommand("setContext", "github-actions.internet-access", canReachAPI);
+      if (canReachAPI) {
+        await workflowTreeProvider.refresh();
+        await settingsTreeProvider.refresh();
+      }
       await executeCacheClearCommand();
     })
   );