Add error handling for missing and invalid configuration files in ConfigLoader

Author: GrantBirki

lib/hooks/core/config_loader.rb

@@ -32,16 +32,24 @@ class ConfigLoader
       #
       # @param config_path [String, Hash] Path to config file or config hash
       # @return [Hash] Merged configuration
+      # @raise [ArgumentError] if config file path is provided but file doesn't exist
+      # @raise [RuntimeError] if config file exists but fails to load
       def self.load(config_path: nil)
         config = DEFAULT_CONFIG.dup
         overrides = []
 
         # Load from file if path provided
-        if config_path.is_a?(String) && File.exist?(config_path)
+        if config_path.is_a?(String)
+          unless File.exist?(config_path)
+            raise ArgumentError, "Configuration file not found: #{config_path}"
+          end
+
           file_config = load_config_file(config_path)
           if file_config
             overrides << "file config"
             config.merge!(file_config)
+          else
+            raise RuntimeError, "Failed to load configuration from file: #{config_path}"
           end
         end
 

spec/unit/lib/hooks/core/config_loader_spec.rb

@@ -101,12 +101,10 @@
       context "when file does not exist" do
         let(:config_file) { File.join(temp_dir, "nonexistent.yml") }
 
-        it "returns default configuration" do
-          config = described_class.load(config_path: config_file)
-
-          expect(config[:log_level]).to eq("info")
-          expect(config[:environment]).to eq("production")
-          expect(config[:production]).to be true
+        it "raises ArgumentError" do
+          expect {
+            described_class.load(config_path: config_file)
+          }.to raise_error(ArgumentError, "Configuration file not found: #{config_file}")
         end
       end
 
@@ -117,11 +115,10 @@
           File.write(config_file, "invalid: yaml: content: [")
         end
 
-        it "returns default configuration" do
-          config = described_class.load(config_path: config_file)
-
-          expect(config[:log_level]).to eq("info")
-          expect(config[:environment]).to eq("production")
+        it "raises RuntimeError" do
+          expect {
+            described_class.load(config_path: config_file)
+          }.to raise_error(RuntimeError, "Failed to load configuration from file: #{config_file}")
         end
       end
 
@@ -132,11 +129,10 @@
           File.write(config_file, "log_level: debug")
         end
 
-        it "returns default configuration" do
-          config = described_class.load(config_path: config_file)
-
-          expect(config[:log_level]).to eq("info")
-          expect(config[:environment]).to eq("production")
+        it "raises RuntimeError" do
+          expect {
+            described_class.load(config_path: config_file)
+          }.to raise_error(RuntimeError, "Failed to load configuration from file: #{config_file}")
         end
       end
     end