move catchall logic out

Author: GrantBirki

lib/hooks/app/api.rb

@@ -142,70 +142,9 @@ def self.create(config:, endpoints:, log:)
           # Catch-all route for unknown endpoints - use default handler
           # Only create if explicitly enabled in config
           if captured_config[:use_catchall_route]
-            post "#{captured_config[:root_path]}/*path" do
-              request_id = SecureRandom.uuid
-
-              # Use captured values
-              config = captured_config
-              log = captured_logger
-
-              # Set request context for logging
-              request_context = {
-                request_id:,
-                path: "/#{params[:path]}",
-                handler: "DefaultHandler"
-              }
-
-              Core::LogContext.with(request_context) do
-                begin
-                  # Enforce request limits
-                  enforce_request_limits(config)
-
-                  # Get raw body for payload parsing
-                  request.body.rewind
-                  raw_body = request.body.read
-
-                  # Parse payload
-                  payload = parse_payload(raw_body, headers)
-
-                  # Use default handler
-                  handler = DefaultHandler.new
-
-                  # Call handler
-                  response = handler.call(
-                    payload: payload,
-                    headers: headers,
-                    config: {}
-                  )
-
-                  log.info "request processed successfully with default handler (id: #{request_id})"
-
-                  # Return response as JSON string when using txt format
-                  status 200
-                  content_type "application/json"
-                  (response || { status: "ok" }).to_json
-
-                rescue StandardError => e
-                  log.error "request failed: #{e.message} (id: #{request_id})"
-
-                  # Return error response
-                  error_response = {
-                    error: e.message,
-                    code: determine_error_code(e),
-                    request_id:
-                  }
-
-                  # Add backtrace in all environments except production
-                  unless config[:production] == true
-                    error_response[:backtrace] = e.backtrace
-                  end
-
-                  status error_response[:code]
-                  content_type "application/json"
-                  error_response.to_json
-                end
-              end
-            end
+            route_path = Hooks::App::CatchallEndpoint.mount_path(captured_config)
+            route_block = Hooks::App::CatchallEndpoint.route_block(captured_config, captured_logger)
+            post(route_path, &route_block)
           end
         end
 

lib/hooks/app/endpoints/catchall.rb

@@ -0,0 +1,81 @@
+# frozen_string_literal: true
+
+require "grape"
+require_relative "../../handlers/default"
+
+module Hooks
+  module App
+    class CatchallEndpoint < Grape::API
+      def self.mount_path(config)
+        "#{config[:root_path]}/*path"
+      end
+
+      def self.route_block(captured_config, captured_logger)
+        proc do
+          request_id = SecureRandom.uuid
+
+          # Use captured values
+          config = captured_config
+          log = captured_logger
+
+          # Set request context for logging
+          request_context = {
+            request_id: request_id,
+            path: "/#{params[:path]}",
+            handler: "DefaultHandler"
+          }
+
+          Hooks::Core::LogContext.with(request_context) do
+            begin
+              # Enforce request limits
+              enforce_request_limits(config)
+
+              # Get raw body for payload parsing
+              request.body.rewind
+              raw_body = request.body.read
+
+              # Parse payload
+              payload = parse_payload(raw_body, headers)
+
+              # Use default handler
+              handler = DefaultHandler.new
+
+              # Call handler
+              response = handler.call(
+                payload: payload,
+                headers: headers,
+                config: {}
+              )
+
+              log.info "request processed successfully with default handler (id: #{request_id})"
+
+              # Return response as JSON string when using txt format
+              status 200
+              content_type "application/json"
+              (response || { status: "ok" }).to_json
+
+            rescue StandardError => e
+              log.error "request failed: #{e.message} (id: #{request_id})"
+
+              # Return error response
+              error_response = {
+                error: e.message,
+                code: determine_error_code(e),
+                request_id: request_id
+              }
+
+              # Add backtrace in all environments except production
+              unless config[:production] == true
+                error_response[:backtrace] = e.backtrace
+              end
+
+              status error_response[:code]
+              content_type "application/json"
+              error_response.to_json
+            end
+          end
+        end
+      end
+    end
+  end
+end