use Semantic Versioning 2.0.0 (the v prefix is not valid)

Author: GrantBirki

lib/entitlements/data/groups/calculated/yaml.rb

@@ -38,12 +38,12 @@ def description
           #
           # Takes no arguments.
           #
-          # Returns a String with the schema version (semver), or "v1.0.0" if undefined.
+          # Returns a String with the schema version (semver), or "1.0.0" if undefined.
           Contract C::None => String
           def schema_version
-            version = parsed_data.fetch("schema_version", "v1.0.0")
-            unless version.match?(/^\Av?\d+\.\d+\.\d+\z$/)
-              raise "Invalid schema version format: #{version} - Expected format is 'MAJOR.MINOR.PATCH' - Examples: v1.2.3 or 1.2.3"
+            version = parsed_data.fetch("schema_version", "1.0.0")
+            unless version.match?(/\A\d+\.\d+\.\d+\z/)
+              raise "Invalid schema version format: #{version} - Expected format is 'MAJOR.MINOR.PATCH' - Examples: 1.2.3 or 10.0.0"
             end
             version
           end

spec/unit/entitlements/data/groups/calculated/yaml_spec.rb

@@ -39,19 +39,19 @@
     it "returns the version string when one is set" do
       filename = fixture("ldap-config/filters/no-filters-with-schema-version.yaml")
       subject = described_class.new(filename: filename)
-      expect(subject.schema_version).to eq("v1.2.3")
+      expect(subject.schema_version).to eq("1.2.3")
     end
 
-    it "returns the version string when one is set (no v prefix)" do
-      filename = fixture("ldap-config/filters/no-filters-with-schema-version-no-v.yaml")
+    it "returns the version string when one is set (with v prefix - not valid semver 2)" do
+      filename = fixture("ldap-config/filters/no-filters-with-schema-version-with-v.yaml")
       subject = described_class.new(filename: filename)
-      expect(subject.schema_version).to eq("1.2.3")
+      expect { subject.schema_version }.to raise_error(RuntimeError, /Invalid schema version format/)
     end
 
     it "returns the default version when schema_version is undefined" do
       filename = fixture("ldap-config/filters/no-filters-description.yaml")
       subject = described_class.new(filename: filename)
-      expect(subject.schema_version).to eq("v1.0.0")
+      expect(subject.schema_version).to eq("1.0.0")
     end
 
     it "throws an error when an invalid semver string is provided" do

spec/unit/fixtures/ldap-config/filters/no-filters-with-bad-schema-version.yaml

@@ -1,5 +1,5 @@
 description: Yo kittens
-schema_version: v1.abc2.3
+schema_version: 1.abc2.3
 rules:
   or:
     - username: russianblue

…no-filters-with-schema-version-no-v.yaml …-filters-with-schema-version-with-v.yamlspec/unit/fixtures/ldap-config/filters/no-filters-with-schema-version-no-v.yaml renamed to spec/unit/fixtures/ldap-config/filters/no-filters-with-schema-version-with-v.yaml spec/unit/fixtures/ldap-config/filters/no-filters-with-schema-version-no-v.yaml renamed to spec/unit/fixtures/ldap-config/filters/no-filters-with-schema-version-with-v.yaml

@@ -1,5 +1,5 @@
 description: Yo kittens
-schema_version: 1.2.3
+schema_version: v1.2.3
 rules:
   or:
     - username: russianblue

spec/unit/fixtures/ldap-config/filters/no-filters-with-schema-version.yaml

@@ -1,5 +1,5 @@
 description: Yo kittens
-schema_version: v1.2.3
+schema_version: 1.2.3
 rules:
   or:
     - username: russianblue