extra semver 2.0 compatibility tests

Author: GrantBirki

lib/entitlements/data/groups/calculated/yaml.rb

@@ -41,9 +41,10 @@ def description
           # Returns a String with the schema version (semver), or "1.0.0" if undefined.
           Contract C::None => String
           def schema_version
-            version = parsed_data.fetch("schema_version", "1.0.0")
+            version = parsed_data.fetch("schema_version", "1.0.0").to_s
             unless version.match?(/\A\d+\.\d+\.\d+\z/)
-              raise "Invalid schema version format: #{version} - Expected format is 'MAJOR.MINOR.PATCH' - Examples: 1.2.3 or 10.0.0"
+              raise "Invalid schema version format: #{version} - Expected format is 'MAJOR.MINOR.PATCH' " \
+                "- Examples: 1.2.3 or 10.0.0"
             end
             version
           end

spec/unit/entitlements/data/groups/calculated/yaml_spec.rb

@@ -42,6 +42,12 @@
       expect(subject.schema_version).to eq("1.2.3")
     end
 
+    it "returns the version string when one is set without the patch - not valid semver 2" do
+      filename = fixture("ldap-config/filters/no-filters-with-schema-version-no-patch.yaml")
+      subject = described_class.new(filename: filename)
+      expect { subject.schema_version }.to raise_error(RuntimeError, /Invalid schema version format/)
+    end
+
     it "returns the version string when one is set (with v prefix - not valid semver 2)" do
       filename = fixture("ldap-config/filters/no-filters-with-schema-version-with-v.yaml")
       subject = described_class.new(filename: filename)

spec/unit/fixtures/ldap-config/filters/no-filters-with-schema-version-no-patch.yaml

@@ -0,0 +1,6 @@
+description: Yo kittens
+schema_version: 1.2
+rules:
+  or:
+    - username: russianblue
+    - username: BlackManx