Refocus on description field semicolon handling per review feedback

Revert parsed_predicate changes and instead add tests ensuring
semicolons in the description free-form text area are preserved
correctly and not treated as predicate separators.

Co-authored-by: northrup <[email protected]>

Author: Copilot

lib/entitlements/data/groups/calculated/text.rb

@@ -316,13 +316,8 @@ def parsed_predicate(val)
             return { key: v } unless v.include?(";")
 
             parts = v.split(/\s*;\s*/)
-            primary_value = parts.shift
-            if primary_value.nil? || primary_value.strip.empty?
-              raise ArgumentError, "Rule Error: Empty value with semicolon predicate in #{filename}!"
-            end
-
-            op_hash = { key: primary_value.strip }
-            parts.reject { |part| part.strip.empty? }.each do |part|
+            op_hash = { key: parts.shift }
+            parts.each do |part|
               if part =~ /\A(\w+)\s*=\s*(\S+)\s*\z/
                 predicate_keyword, predicate_value = Regexp.last_match(1), Regexp.last_match(2)
                 unless SEMICOLON_PREDICATES.include?(predicate_keyword)

spec/unit/entitlements/data/groups/calculated/text_spec.rb

@@ -60,6 +60,24 @@
         subject.description
       end.to raise_error(RuntimeError, /description cannot use '!=' operator in .+not-equals-description.txt!/)
     end
+
+    it "preserves semicolons in a free-form narrative description" do
+      filename = fixture("ldap-config/text/description-with-semicolon-narrative.txt")
+      subject = described_class.new(filename: filename)
+      expect(subject.description).to eq("This group manages auth; it also handles access control for the team")
+    end
+
+    it "does not parse semicolons in description as predicates" do
+      filename = fixture("ldap-config/text/semicolons-in-description.txt")
+      subject = described_class.new(filename: filename)
+      expect(subject.description).to eq("the; description; can; have; semicolons")
+    end
+
+    it "does not treat predicate-like text after semicolons in description as predicates" do
+      filename = fixture("ldap-config/text/description-with-predicate-like-semicolon.txt")
+      subject = described_class.new(filename: filename)
+      expect(subject.description).to eq("This group provides access to resources; expiration = 2099-12-31 is not a predicate here")
+    end
   end
 
   describe "#initialize_filters" do
@@ -589,38 +607,5 @@
         expect(result).to eq(answer)
       end
     end
-
-    context "with a leading semicolon in the value" do
-      let(:filename) { fixture("ldap-config/text/leading-semicolon.txt") }
-
-      it "raises an error about empty value" do
-        expect do
-          subject.send(:parsed_data)
-        end.to raise_error(ArgumentError, /Rule Error: Empty value with semicolon predicate in .+leading-semicolon.txt!/)
-      end
-    end
-
-    context "with only a semicolon as the value" do
-      let(:filename) { fixture("ldap-config/text/only-semicolon.txt") }
-
-      it "raises an error about empty value" do
-        expect do
-          subject.send(:parsed_data)
-        end.to raise_error(ArgumentError, /Rule Error: Empty value with semicolon predicate in .+only-semicolon.txt!/)
-      end
-    end
-
-    context "with a trailing semicolon in the value" do
-      let(:filename) { fixture("ldap-config/text/trailing-semicolon.txt") }
-
-      it "parses correctly ignoring trailing semicolon" do
-        result = subject.send(:parsed_data)
-        answer = {
-          "description" => {"=" => [{ key: "Trailing semicolon test" }], "!=" => [], "&=" => []},
-          "username" => {"=" => [{ key: "blackmanx" }], "!=" => [], "&=" => []}
-        }
-        expect(result).to eq(answer)
-      end
-    end
   end
 end

spec/unit/fixtures/ldap-config/text/description-with-predicate-like-semicolon.txt

@@ -0,0 +1,2 @@
+description = This group provides access to resources; expiration = 2099-12-31 is not a predicate here
+username = mainecoon

spec/unit/fixtures/ldap-config/text/description-with-semicolon-narrative.txt

@@ -0,0 +1,2 @@
+description = This group manages auth; it also handles access control for the team
+username = mainecoon