Skip to content

Commit e0db9bd

Browse files
logaretmclaude
andcommitted
fix(tests): Catch the missed assertion shapes and revert init.js noise
- Update tanstack-router (solid/react/vue) e2e tests: drop measurements expectations, swap to `browser.web_vital.{ttfb,fp,fcp}.value` attribute checks on the pageload trace data. LCP intentionally not asserted (fires at pagehide, lost in static mode). - Update connection-rtt browser-integration test to look at `network.connection.rtt` attribute instead of the removed `measurements['connection.rtt']`. - Update react-create-{browser,hash}-router e2e transactions tests to use the new OTel-style attribute names (`device.memory.estimated_capacity`, `network.connection.effective_type`, `device.processor_count`, `browser.performance.time_origin`, `browser.performance.navigation.activation_start`). Drop legacy `lcp.*` data assertions. - Delete browser-integration suites for `experimental: { standalone: true }` (`public-api/startSpan/standalone`, `standalone-mixed-transaction`). They exercised a removed code path. - Revert the prior `webVitalsIntegration({ disable: ['inp'] })` additions to init.js files (long-tasks/animation-frame, linked-traces). The `enableInp` removal alone is enough; auto-registered web vitals don't affect those navigation/long-task tests. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
1 parent 049f2a2 commit e0db9bd

18 files changed

Lines changed: 45 additions & 294 deletions

File tree

dev-packages/browser-integration-tests/suites/public-api/startSpan/standalone-mixed-transaction/init.js

Lines changed: 0 additions & 8 deletions
This file was deleted.

dev-packages/browser-integration-tests/suites/public-api/startSpan/standalone-mixed-transaction/subject.js

Lines changed: 0 additions & 4 deletions
This file was deleted.

dev-packages/browser-integration-tests/suites/public-api/startSpan/standalone-mixed-transaction/test.ts

Lines changed: 0 additions & 129 deletions
This file was deleted.

dev-packages/browser-integration-tests/suites/public-api/startSpan/standalone/init.js

Lines changed: 0 additions & 8 deletions
This file was deleted.

dev-packages/browser-integration-tests/suites/public-api/startSpan/standalone/subject.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

dev-packages/browser-integration-tests/suites/public-api/startSpan/standalone/test.ts

Lines changed: 0 additions & 58 deletions
This file was deleted.

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces-streamed/consistent-sampling/tracesSampler-precedence/init.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ window.Sentry = Sentry;
55
Sentry.init({
66
dsn: 'https://[email protected]/1337',
77
integrations: [
8-
Sentry.webVitalsIntegration({ disable: ['inp'] }),
98
Sentry.browserTracingIntegration({
109
linkPreviousTrace: 'in-memory',
1110
consistentTraceSampling: true,

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/tracesSampler-precedence/init.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ window.Sentry = Sentry;
55
Sentry.init({
66
dsn: 'https://[email protected]/1337',
77
integrations: [
8-
Sentry.webVitalsIntegration({ disable: ['inp'] }),
98
Sentry.browserTracingIntegration({
109
linkPreviousTrace: 'in-memory',
1110
consistentTraceSampling: true,

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/long-animation-frame-before-navigation-streamed/init.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ window.Sentry = Sentry;
55
Sentry.init({
66
dsn: 'https://[email protected]/1337',
77
integrations: [
8-
Sentry.webVitalsIntegration({ disable: ['inp'] }),
98
Sentry.browserTracingIntegration({
109
enableLongTask: false,
1110
enableLongAnimationFrame: true,

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/long-animation-frame-before-navigation/init.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ window.Sentry = Sentry;
55
Sentry.init({
66
dsn: 'https://[email protected]/1337',
77
integrations: [
8-
Sentry.webVitalsIntegration({ disable: ['inp'] }),
98
Sentry.browserTracingIntegration({
109
enableLongTask: false,
1110
enableLongAnimationFrame: true,

0 commit comments

Comments
 (0)