-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Expand file tree
/
Copy pathattributes.test.ts
More file actions
447 lines (401 loc) · 14.3 KB
/
attributes.test.ts
File metadata and controls
447 lines (401 loc) · 14.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
import { describe, expect, it } from 'vitest';
import { attributeValueToTypedAttributeValue, isAttributeObject, serializeAttributes } from '../../src/attributes';
describe('attributeValueToTypedAttributeValue', () => {
describe('without fallback (default behavior)', () => {
describe('valid primitive values', () => {
it('converts a string value to a typed attribute value', () => {
const result = attributeValueToTypedAttributeValue('test');
expect(result).toStrictEqual({
value: 'test',
type: 'string',
});
});
it.each([42, 42.0])('converts an integer number value to a typed attribute value (%s)', value => {
const result = attributeValueToTypedAttributeValue(value);
expect(result).toStrictEqual({
value: value,
type: 'integer',
});
});
it('converts a double number value to a typed attribute value', () => {
const result = attributeValueToTypedAttributeValue(42.34);
expect(result).toStrictEqual({
value: 42.34,
type: 'double',
});
});
it('converts a boolean value to a typed attribute value', () => {
const result = attributeValueToTypedAttributeValue(true);
expect(result).toStrictEqual({
value: true,
type: 'boolean',
});
});
});
describe('valid attribute objects', () => {
it('converts a primitive value without unit to a typed attribute value', () => {
const result = attributeValueToTypedAttributeValue({ value: 123.45 });
expect(result).toStrictEqual({
value: 123.45,
type: 'double',
});
});
it('converts a primitive value with unit to a typed attribute value', () => {
const result = attributeValueToTypedAttributeValue({ value: 123.45, unit: 'ms' });
expect(result).toStrictEqual({
value: 123.45,
type: 'double',
unit: 'ms',
});
});
it('extracts the value property and ignores other properties', () => {
const result = attributeValueToTypedAttributeValue({ value: 'foo', unit: 'ms', bar: 'baz' });
expect(result).toStrictEqual({
value: 'foo',
unit: 'ms',
type: 'string',
});
});
it.each([1, true, null, undefined, NaN, Symbol('test'), { foo: 'bar' }])(
'ignores invalid (non-string) units (%s)',
unit => {
const result = attributeValueToTypedAttributeValue({ value: 'foo', unit });
expect(result).toStrictEqual({
value: 'foo',
type: 'string',
});
},
);
});
describe('homogeneous primitive arrays', () => {
it.each([[['foo', 'bar']], [[1, 2, 3]], [[true, false, true]], [[] as unknown[]]])(
'emits a typed array attribute for raw value %j',
value => {
const result = attributeValueToTypedAttributeValue(value);
expect(result).toStrictEqual({ value, type: 'array' });
},
);
it('emits a typed array attribute for attribute object values', () => {
const result = attributeValueToTypedAttributeValue({ value: ['foo', 'bar'] });
expect(result).toStrictEqual({ value: ['foo', 'bar'], type: 'array' });
});
});
describe('invalid values (non-primitives)', () => {
it.each([[[1, 'foo', true]], [{ foo: 'bar' }], [() => 'test'], [Symbol('test')]])(
'returns undefined for non-primitive raw values (%s)',
value => {
const result = attributeValueToTypedAttributeValue(value);
expect(result).toBeUndefined();
},
);
it.each([[[1, 'foo', true]], [{ foo: 'bar' }], [() => 'test'], [Symbol('test')]])(
'returns undefined for non-primitive attribute object values (%s)',
value => {
const result = attributeValueToTypedAttributeValue({ value });
expect(result).toBeUndefined();
},
);
});
});
describe('with fallback=true', () => {
describe('valid primitive values', () => {
it('converts a string value to a typed attribute value', () => {
const result = attributeValueToTypedAttributeValue('test', true);
expect(result).toStrictEqual({
value: 'test',
type: 'string',
});
});
it('converts an integer number value to a typed attribute value', () => {
const result = attributeValueToTypedAttributeValue(42, true);
expect(result).toStrictEqual({
value: 42,
type: 'integer',
});
});
it('converts a double number value to a typed attribute value', () => {
const result = attributeValueToTypedAttributeValue(42.34, true);
expect(result).toStrictEqual({
value: 42.34,
type: 'double',
});
});
it('converts a boolean value to a typed attribute value', () => {
const result = attributeValueToTypedAttributeValue(true, true);
expect(result).toStrictEqual({
value: true,
type: 'boolean',
});
});
});
describe('valid attribute objects', () => {
it('converts a primitive value without unit to a typed attribute value', () => {
const result = attributeValueToTypedAttributeValue({ value: 123.45 }, true);
expect(result).toStrictEqual({
value: 123.45,
type: 'double',
});
});
it('converts a primitive value with unit to a typed attribute value', () => {
const result = attributeValueToTypedAttributeValue({ value: 123.45, unit: 'ms' }, true);
expect(result).toStrictEqual({
value: 123.45,
type: 'double',
unit: 'ms',
});
});
it('extracts the value property and ignores other properties', () => {
const result = attributeValueToTypedAttributeValue({ value: 'foo', unit: 'ms', bar: 'baz' }, true);
expect(result).toStrictEqual({
value: 'foo',
unit: 'ms',
type: 'string',
});
});
it.each([1, true, null, undefined, NaN, { foo: 'bar' }])(
'ignores invalid (non-string) units and preserves unit on fallback (%s)',
unit => {
const result = attributeValueToTypedAttributeValue({ value: 'foo', unit }, true);
expect(result).toStrictEqual({
value: 'foo',
type: 'string',
});
},
);
it('preserves valid unit when falling back on invalid value', () => {
const result = attributeValueToTypedAttributeValue({ value: { nested: 'object' }, unit: 'ms' }, true);
expect(result).toStrictEqual({
value: '{"nested":"object"}',
type: 'string',
unit: 'ms',
});
});
});
describe('invalid values (non-primitives) - stringified fallback', () => {
it('stringifies mixed-type arrays (not homogeneous)', () => {
const result = attributeValueToTypedAttributeValue(['foo', 1, true], true);
expect(result).toStrictEqual({
value: '["foo",1,true]',
type: 'string',
});
});
it('stringifies mixed arrays', () => {
const result = attributeValueToTypedAttributeValue([1, 'foo', true], true);
expect(result).toStrictEqual({
value: '[1,"foo",true]',
type: 'string',
});
});
it('stringifies objects', () => {
const result = attributeValueToTypedAttributeValue({ foo: 'bar' }, true);
expect(result).toStrictEqual({
value: '{"foo":"bar"}',
type: 'string',
});
});
it('returns empty string for non-stringifiable values (functions)', () => {
const result = attributeValueToTypedAttributeValue(() => 'test', true);
expect(result).toStrictEqual({
value: '',
type: 'string',
});
});
it('returns empty string for non-stringifiable values (symbols)', () => {
const result = attributeValueToTypedAttributeValue(Symbol('test'), true);
expect(result).toStrictEqual({
value: '',
type: 'string',
});
});
it('returns empty string if JSON.stringify fails', () => {
const result = attributeValueToTypedAttributeValue(
{
toJSON: () => {
throw new Error('test');
},
},
true,
);
expect(result).toStrictEqual({
value: '',
type: 'string',
});
});
it('stringifies non-primitive attribute object values', () => {
const result = attributeValueToTypedAttributeValue({ value: { nested: 'object' } }, true);
expect(result).toStrictEqual({
value: '{"nested":"object"}',
type: 'string',
});
});
it.each([null, { value: null }, { value: null, unit: 'byte' }])('stringifies %s values', value => {
const result = attributeValueToTypedAttributeValue(value, true);
expect(result).toMatchObject({
value: 'null',
type: 'string',
});
});
it.each([undefined, { value: undefined }])('stringifies %s values to ""', value => {
const result = attributeValueToTypedAttributeValue(value, true);
expect(result).toEqual({
value: '',
type: 'string',
});
});
it('stringifies undefined values with unit to ""', () => {
const result = attributeValueToTypedAttributeValue({ value: undefined, unit: 'byte' }, true);
expect(result).toEqual({
value: '',
unit: 'byte',
type: 'string',
});
});
});
});
describe('with fallback="skip-undefined"', () => {
it.each([undefined, { value: undefined }, { value: undefined, unit: 'byte' }])(
'ignores undefined values (%s)',
value => {
const result = attributeValueToTypedAttributeValue(value, 'skip-undefined');
expect(result).toBeUndefined();
},
);
});
});
describe('isAttributeObject', () => {
it.each([
{ value: 123.45, unit: 'ms' },
{ value: [true, false], unit: 'count' },
{ value: { foo: 'bar' }, unit: 'bytes' },
{ value: { value: 123.45, unit: 'ms' }, unit: 'ms' },
{ value: 1 },
])('returns true for a valid attribute object (%s)', obj => {
const result = isAttributeObject(obj);
expect(result).toBe(true);
});
it('returns true for an object with a value property', () => {
// Explicitly demonstrate this behaviour which for now we're fine with.
// We may reconsider in the future.
expect(isAttributeObject({ value: 123.45, some: 'other property' })).toBe(true);
});
it.each([1, true, 'test', null, undefined, NaN, Symbol('test')])(
'returns false for an invalid attribute object (%s)',
obj => {
const result = isAttributeObject(obj);
expect(result).toBe(false);
},
);
});
describe('serializeAttributes', () => {
it('returns an empty object for undefined attributes', () => {
const result = serializeAttributes(undefined);
expect(result).toStrictEqual({});
});
it('returns an empty object for an empty object', () => {
const result = serializeAttributes({});
expect(result).toStrictEqual({});
});
it('serializes valid, non-primitive values', () => {
const result = serializeAttributes({ foo: 'bar', bar: { value: 123 }, baz: { value: 456, unit: 'byte' } });
expect(result).toStrictEqual({
bar: {
type: 'integer',
value: 123,
},
baz: {
type: 'integer',
unit: 'byte',
value: 456,
},
foo: {
type: 'string',
value: 'bar',
},
});
});
it('ignores undefined values if fallback is false', () => {
const result = serializeAttributes(
{ foo: undefined, bar: { value: undefined }, baz: { value: undefined, unit: 'byte' } },
false,
);
expect(result).toStrictEqual({});
});
it('ignores undefined values if fallback is "skip-undefined"', () => {
const result = serializeAttributes(
{ foo: undefined, bar: { value: undefined }, baz: { value: undefined, unit: 'byte' } },
'skip-undefined',
);
expect(result).toStrictEqual({});
});
it('stringifies undefined values to "" if fallback is true', () => {
const result = serializeAttributes(
{ foo: undefined, bar: { value: undefined }, baz: { value: undefined, unit: 'byte' } },
true,
);
expect(result).toStrictEqual({
bar: {
type: 'string',
value: '',
},
baz: {
type: 'string',
unit: 'byte',
value: '',
},
foo: { type: 'string', value: '' },
});
});
it('ignores null values by default', () => {
const result = serializeAttributes({ foo: null, bar: { value: null }, baz: { value: null, unit: 'byte' } });
expect(result).toStrictEqual({});
});
it('stringifies to `"null"` if fallback is true', () => {
const result = serializeAttributes({ foo: null, bar: { value: null }, baz: { value: null, unit: 'byte' } }, true);
expect(result).toStrictEqual({
foo: {
type: 'string',
value: 'null',
},
bar: {
type: 'string',
value: 'null',
},
baz: {
type: 'string',
unit: 'byte',
value: 'null',
},
});
});
describe('invalid (non-primitive) values', () => {
it("doesn't fall back to stringification by default", () => {
const result = serializeAttributes({ foo: { some: 'object' }, bar: [1, 2, 3], baz: () => {} });
expect(result).toStrictEqual({
bar: { type: 'array', value: [1, 2, 3] },
});
});
it('falls back to stringification of unsupported non-primitive values if fallback is true', () => {
const result = serializeAttributes({ foo: { some: 'object' }, bar: [1, 2, 3], baz: () => {} }, true);
expect(result).toStrictEqual({
bar: {
type: 'array',
value: [1, 2, 3],
},
baz: {
type: 'string',
value: '',
},
foo: {
type: 'string',
value: '{"some":"object"}',
},
});
});
it('drops mixed-type arrays by default and stringifies them with fallback', () => {
expect(serializeAttributes({ mixed: ['a', 1] })).toStrictEqual({});
expect(serializeAttributes({ mixed: ['a', 1] }, true)).toStrictEqual({
mixed: { type: 'string', value: '["a",1]' },
});
});
});
});