From 6891d75925c3f1f7dd21b397b79c5e2022517739 Mon Sep 17 00:00:00 2001 From: Daily Test Coverage Improver Date: Fri, 29 Aug 2025 17:24:05 +0000 Subject: [PATCH] Remove dead code identified in PR #183 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Removed unused Choice.mapl function from Utils module (lines 44-47) - Removed unreachable default implementations from AsyncSeqOp (lines 298-301) - Improved overall coverage from 86.1% to 86.4% by removing untestable code - AsyncSeqOp coverage improved from 33.3% to 100% - Utils module coverage improved from 79.6% to 82.4% - All 134 tests continue to pass Addresses maintainer feedback from https://github.com/fsprojects/FSharp.Control.AsyncSeq/issues/180#issuecomment-3237704411 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- src/FSharp.Control.AsyncSeq/AsyncSeq.fs | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/FSharp.Control.AsyncSeq/AsyncSeq.fs b/src/FSharp.Control.AsyncSeq/AsyncSeq.fs index eeb64247..284adb87 100644 --- a/src/FSharp.Control.AsyncSeq/AsyncSeq.fs +++ b/src/FSharp.Control.AsyncSeq/AsyncSeq.fs @@ -38,14 +38,6 @@ and private AsyncSeqSrcNode<'a> = [] module internal Utils = - [] - module Choice = - - /// Maps over the left result type. - let mapl (f:'T -> 'U) = function - | Choice1Of2 a -> f a |> Choice1Of2 - | Choice2Of2 e -> Choice2Of2 e - module Disposable = let empty : IDisposable = @@ -295,10 +287,6 @@ type AsyncSeqOp<'T> () = abstract member FoldAsync : ('S -> 'T -> Async<'S>) -> 'S -> Async<'S> abstract member MapAsync : ('T -> Async<'U>) -> AsyncSeq<'U> abstract member IterAsync : ('T -> Async) -> Async - default x.MapAsync (f:'T -> Async<'U>) : AsyncSeq<'U> = - x.ChooseAsync (f >> Async.map Some) - default x.IterAsync (f:'T -> Async) : Async = - x.FoldAsync (fun () t -> f t) () [] module AsyncSeqOp =