Commit dde453c
tests: scope SL_DEBUG_DISABLE_SYMLINKS to Windows only
Summary:
The `SL_DEBUG_DISABLE_SYMLINKS` was changed to be Windows-only in D71445977.
Update tests to only set it on Windows. `test-no-symlinks.t` now uses `#require
no-symlinks` to cover non-symlink filesystems.
I chose this instead of respecting `SL_DEBUG_DISABLE_SYMLINKS` on non-Windows
platforms because:
- Setting this environment variable on non-Windows can be a footgun for users.
- This environment variable can be deleted once our Windows users are all using
symlinks. This diff makes it slightly easier to delete.
Reviewed By: muirdm
Differential Revision: D71666114
fbshipit-source-id: 67dd72b4eed768d8d4a9ab43a1a22a4894af59b71 parent fd2f770 commit dde453c
4 files changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | 7 | | |
10 | 8 | | |
11 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
593 | 593 | | |
594 | 594 | | |
595 | 595 | | |
596 | | - | |
| 596 | + | |
597 | 597 | | |
598 | 598 | | |
599 | 599 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
325 | 325 | | |
326 | 326 | | |
327 | 327 | | |
| 328 | + | |
328 | 329 | | |
329 | 330 | | |
330 | 331 | | |
331 | 332 | | |
332 | 333 | | |
| 334 | + | |
0 commit comments