log inode loading failures on Linux/Windows

MichaelCuevas · facebook-github-bot · commit b98c1c08dc29 · 2025-03-24T20:48:07.000-07:00
Summary:
# This diff

Removes some conditional compilation so that we can log inode loading failure events on all platforms

Reviewed By: kavehahmadi60

Differential Revision: D71419250

fbshipit-source-id: f359546241af00bb68f94dc1fb95f00481d3806f
diff --git a/eden/fs/inodes/InodeMap.cpp b/eden/fs/inodes/InodeMap.cpp
@@ -540,12 +540,10 @@ void InodeMap::inodeLoadFailed(
     mount_->publishInodeTraceEvent(std::move(optionalFailEvent.value()));
   }
 
-#ifdef __APPLE__
   // Temporarily log every inode load failure and associated error string.
   // This data will help us understand the impact of X2P errors on EdenFS.
   structuredLogger_->logEvent(
       InodeLoadingFailed{errStr.toStdString(), number.getRawValue()});
-#endif // __APPLE__
   stats_->increment(&InodeMapStats::lookupInodeError, promises.size());
 }
 

Original file line number	Diff line number	Diff line change
`@@ -540,12 +540,10 @@ void InodeMap::inodeLoadFailed(`
`540`	`540`	`mount_->publishInodeTraceEvent(std::move(optionalFailEvent.value()));`
`541`	`541`	`}`
`542`	`542`
`543`		`-#ifdef __APPLE__`
`544`	`543`	`// Temporarily log every inode load failure and associated error string.`
`545`	`544`	`// This data will help us understand the impact of X2P errors on EdenFS.`
`546`	`545`	`structuredLogger_->logEvent(`
`547`	`546`	`InodeLoadingFailed{errStr.toStdString(), number.getRawValue()});`
`548`		`-#endif // __APPLE__`
`549`	`547`	`stats_->increment(&InodeMapStats::lookupInodeError, promises.size());`
`550`	`548`	`}`
`551`	`549`