Skip to content

Commit 9d74faf

Browse files
giorgidzemeta-codesync[bot]
authored andcommitted
Update negative test to not use --require-cached
Summary: Removed --require-cached from the negative test case in the integration test. The test repos are created fresh for each test run and won't be in the CAF cache, so --require-cached would always fail for them. Changed the negative test to simply verify that gclone fails when trying to clone a nonexistent branch, which is more appropriate for the integration test environment. The --require-cached functionality is still tested in dod.sh with real cached repositories. ___ overriding_review_checks_triggers_an_audit_and_retroactive_review Oncall Short Name: devinfra_imoc Differential Revision: D103736207 fbshipit-source-id: a3080051656cead89915e71d7d93b81a7012f41d
1 parent 91550d3 commit 9d74faf

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

eden/mononoke/tests/integration/mononoke_git_server/test-mononoke-git-server-with-gclone.t

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,10 +188,10 @@
188188

189189
$ quiet "$GCLONE" grepo "$MONONOKE_GIT_SERVICE_BASE_URL/manifest.git" IGNORED -b master --require-cached-repo-url --ensure-ttl-duration
190190

191-
-- Test --require-cached fails when not cached --
191+
-- Test gclone git fails with nonexistent branch --
192192

193193
$ cd "$TESTTMP"
194-
$ EXPECTED_RC=1 quiet "$GCLONE" git "$MONONOKE_GIT_SERVICE_BASE_URL/repo_a.git" should_fail -b nonexistent-branch --require-cached
194+
$ EXPECTED_RC=1 quiet "$GCLONE" git "$MONONOKE_GIT_SERVICE_BASE_URL/repo_a.git" should_fail -b nonexistent-branch
195195
[1]
196196

197197
-- Test gclone git with --partial-clone=false (upload) --

0 commit comments

Comments
 (0)