Remove get_server_build_info_legacy (migration complete)

Summary: Remove the legacy get_server_build_info_legacy function now that all callers have been migrated to the modern thrift-python implementation.

Reviewed By: muirdm

Differential Revision: D90630677

fbshipit-source-id: b398c2ace6b2eba929d7fa26871e124858307cee

Author: SBones

eden/fs/cli/config.py

@@ -490,7 +490,7 @@ def get_running_version_parts(self) -> Tuple[str, str]:
 
         Throws an EdenNotRunningError if EdenFS does not currently appear to be running.
         """
-        bi = self.get_server_build_info_legacy()
+        bi = self.get_server_build_info()
         return (
             bi.get("build_package_version", ""),
             bi.get("build_package_release", ""),
@@ -1314,10 +1314,6 @@ def _get_client_dir_for_mount_point(self, path: Path) -> Path:
     def _get_clients_dir(self) -> Path:
         return self._config_dir / CLIENTS_DIR
 
-    def get_server_build_info_legacy(self) -> Dict[str, str]:
-        with self.get_thrift_client_legacy(timeout=3) as client:
-            return client.getRegexExportedValues("^build_.*")
-
     def get_server_build_info(self) -> Dict[str, str]:
         with self.get_thrift_client(timeout=3) as client:
             return dict(client.getRegexExportedValues("^build_.*"))

eden/fs/cli/doctor/test/lib/fake_eden_instance.py

@@ -285,9 +285,6 @@ def check_health(self) -> HealthStatus:
     def check_privhelper_connection(self) -> bool:
         return True
 
-    def get_server_build_info_legacy(self) -> Dict[str, str]:
-        return dict(self._build_info)
-
     def get_server_build_info(self) -> Dict[str, str]:
         return dict(self._build_info)
 

eden/fs/service/BUCK

@@ -391,8 +391,8 @@ cpp_library(
         "//folly/chrono:conv",
         "//folly/coro:collect",
         "//folly/coro:invoke",
-        "//folly/executors:cpu_thread_pool_executor",
         "//folly/executors/thread_factory:named_thread_factory",
+        "//folly/executors:cpu_thread_pool_executor",
         "//folly/io/async:async_signal_handler",
         "//folly/json:dynamic",
         "//folly/logging:logging",