Commit 0498384
integration: fix test_change_casing_with_untracked on Windows
Summary:
In D36914467 (e7918c1), a very subtle change was introduced in the processBothChanged
lambda. The path component being used before was the one from the tree, while
it is now coming from the inode itself. This change caused the
test_change_casing_with_untracked to start failing with:
AssertionError: {'DIR2/untracked': '?'} != {'dir2/untracked': '?'}
- {'DIR2/untracked': '?'}
? ^^^
+ {'dir2/untracked': '?'}
? ^^^
Or in english, the test expected the untracked file to be in the directory
DIR2, but is now in the directory dir2. Reading the test itself, and the
comment just above the failed assert makes it clear that on Windows, the dir2
directory will be on disk. It thus makes more sense for status to report the
untracked file from the dir2 directory instead of from the DIR2 directory.
Reviewed By: DurhamG
Differential Revision: D37536084
fbshipit-source-id: 02dd592719f41ad0320f065ccfe41dc64d0306081 parent aa0cd3e commit 0498384
1 file changed
Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
666 | 666 | | |
667 | 667 | | |
668 | 668 | | |
669 | | - | |
670 | | - | |
671 | | - | |
| 669 | + | |
672 | 670 | | |
673 | 671 | | |
674 | 672 | | |
| |||
0 commit comments