Skip to content

Commit dbab82f

Browse files
andyleisersonteoxoy
andyleiserson
authored and
teoxoy
committed
chore(naga): Downgrade some log messages to debug
1 parent 28bc72f commit dbab82f

1 file changed

Lines changed: 23 additions & 23 deletions

File tree

‎naga/src/valid/expression.rs‎

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ impl super::Validator {
273273
| Ti::ValuePointer { size: Some(_), .. }
274274
| Ti::BindingArray { .. } => {}
275275
ref other => {
276-
log::error!("Indexing of {other:?}");
276+
log::debug!("Indexing of {other:?}");
277277
return Err(ExpressionError::InvalidBaseType(base));
278278
}
279279
};
@@ -284,7 +284,7 @@ impl super::Validator {
284284
..
285285
}) => {}
286286
ref other => {
287-
log::error!("Indexing by {other:?}");
287+
log::debug!("Indexing by {other:?}");
288288
return Err(ExpressionError::InvalidIndexType(index));
289289
}
290290
}
@@ -342,7 +342,7 @@ impl super::Validator {
342342
}
343343
Ti::Struct { ref members, .. } => members.len() as u32,
344344
ref other => {
345-
log::error!("Indexing of {other:?}");
345+
log::debug!("Indexing of {other:?}");
346346
return Err(ExpressionError::InvalidBaseType(top));
347347
}
348348
};
@@ -358,7 +358,7 @@ impl super::Validator {
358358
E::Splat { size: _, value } => match resolver[value] {
359359
Ti::Scalar { .. } => ShaderStages::all(),
360360
ref other => {
361-
log::error!("Splat scalar type {other:?}");
361+
log::debug!("Splat scalar type {other:?}");
362362
return Err(ExpressionError::InvalidSplatType(value));
363363
}
364364
},
@@ -370,7 +370,7 @@ impl super::Validator {
370370
let vec_size = match resolver[vector] {
371371
Ti::Vector { size: vec_size, .. } => vec_size,
372372
ref other => {
373-
log::error!("Swizzle vector type {other:?}");
373+
log::debug!("Swizzle vector type {other:?}");
374374
return Err(ExpressionError::InvalidVectorType(vector));
375375
}
376376
};
@@ -414,7 +414,7 @@ impl super::Validator {
414414
.contains(TypeFlags::SIZED | TypeFlags::DATA) => {}
415415
Ti::ValuePointer { .. } => {}
416416
ref other => {
417-
log::error!("Loading {other:?}");
417+
log::debug!("Loading {other:?}");
418418
return Err(ExpressionError::InvalidPointerType(pointer));
419419
}
420420
}
@@ -786,7 +786,7 @@ impl super::Validator {
786786
| (Uo::LogicalNot, Some(Sk::Bool))
787787
| (Uo::BitwiseNot, Some(Sk::Sint | Sk::Uint)) => {}
788788
other => {
789-
log::error!("Op {op:?} kind {other:?}");
789+
log::debug!("Op {op:?} kind {other:?}");
790790
return Err(ExpressionError::InvalidUnaryOperandType(op, expr));
791791
}
792792
}
@@ -903,7 +903,7 @@ impl super::Validator {
903903
Sk::Bool | Sk::AbstractInt | Sk::AbstractFloat => false,
904904
},
905905
ref other => {
906-
log::error!("Op {op:?} left type {other:?}");
906+
log::debug!("Op {op:?} left type {other:?}");
907907
false
908908
}
909909
}
@@ -915,7 +915,7 @@ impl super::Validator {
915915
..
916916
} => left_inner == right_inner,
917917
ref other => {
918-
log::error!("Op {op:?} left type {other:?}");
918+
log::debug!("Op {op:?} left type {other:?}");
919919
false
920920
}
921921
},
@@ -925,7 +925,7 @@ impl super::Validator {
925925
Sk::Float | Sk::AbstractInt | Sk::AbstractFloat => false,
926926
},
927927
ref other => {
928-
log::error!("Op {op:?} left type {other:?}");
928+
log::debug!("Op {op:?} left type {other:?}");
929929
false
930930
}
931931
},
@@ -935,7 +935,7 @@ impl super::Validator {
935935
Sk::Bool | Sk::Float | Sk::AbstractInt | Sk::AbstractFloat => false,
936936
},
937937
ref other => {
938-
log::error!("Op {op:?} left type {other:?}");
938+
log::debug!("Op {op:?} left type {other:?}");
939939
false
940940
}
941941
},
@@ -944,7 +944,7 @@ impl super::Validator {
944944
Ti::Scalar(scalar) => (Ok(None), scalar),
945945
Ti::Vector { size, scalar } => (Ok(Some(size)), scalar),
946946
ref other => {
947-
log::error!("Op {op:?} base type {other:?}");
947+
log::debug!("Op {op:?} base type {other:?}");
948948
(Err(()), Sc::BOOL)
949949
}
950950
};
@@ -955,7 +955,7 @@ impl super::Validator {
955955
scalar: Sc { kind: Sk::Uint, .. },
956956
} => Ok(Some(size)),
957957
ref other => {
958-
log::error!("Op {op:?} shift type {other:?}");
958+
log::debug!("Op {op:?} shift type {other:?}");
959959
Err(())
960960
}
961961
};
@@ -966,12 +966,12 @@ impl super::Validator {
966966
}
967967
};
968968
if !good {
969-
log::error!(
969+
log::debug!(
970970
"Left: {:?} of type {:?}",
971971
function.expressions[left],
972972
left_inner
973973
);
974-
log::error!(
974+
log::debug!(
975975
"Right: {:?} of type {:?}",
976976
function.expressions[right],
977977
right_inner
@@ -1060,15 +1060,15 @@ impl super::Validator {
10601060
..
10611061
} => {}
10621062
ref other => {
1063-
log::error!("All/Any of type {other:?}");
1063+
log::debug!("All/Any of type {other:?}");
10641064
return Err(ExpressionError::InvalidBooleanVector(argument));
10651065
}
10661066
},
10671067
Rf::IsNan | Rf::IsInf => match *argument_inner {
10681068
Ti::Scalar(scalar) | Ti::Vector { scalar, .. }
10691069
if scalar.kind == Sk::Float => {}
10701070
ref other => {
1071-
log::error!("Float test of type {other:?}");
1071+
log::debug!("Float test of type {other:?}");
10721072
return Err(ExpressionError::InvalidFloatArgument(argument));
10731073
}
10741074
},
@@ -1206,7 +1206,7 @@ impl super::Validator {
12061206
}
12071207
}
12081208
ref other => {
1209-
log::error!("Array length of {other:?}");
1209+
log::debug!("Array length of {other:?}");
12101210
return Err(ExpressionError::InvalidArrayType(expr));
12111211
}
12121212
},
@@ -1221,12 +1221,12 @@ impl super::Validator {
12211221
} => match resolver.types[base].inner {
12221222
Ti::RayQuery { .. } => ShaderStages::all(),
12231223
ref other => {
1224-
log::error!("Intersection result of a pointer to {other:?}");
1224+
log::debug!("Intersection result of a pointer to {other:?}");
12251225
return Err(ExpressionError::InvalidRayQueryType(query));
12261226
}
12271227
},
12281228
ref other => {
1229-
log::error!("Intersection result of {other:?}");
1229+
log::debug!("Intersection result of {other:?}");
12301230
return Err(ExpressionError::InvalidRayQueryType(query));
12311231
}
12321232
},
@@ -1242,12 +1242,12 @@ impl super::Validator {
12421242
vertex_return: true,
12431243
} => ShaderStages::all(),
12441244
ref other => {
1245-
log::error!("Intersection result of a pointer to {other:?}");
1245+
log::debug!("Intersection result of a pointer to {other:?}");
12461246
return Err(ExpressionError::InvalidRayQueryType(query));
12471247
}
12481248
},
12491249
ref other => {
1250-
log::error!("Intersection result of {other:?}");
1250+
log::debug!("Intersection result of {other:?}");
12511251
return Err(ExpressionError::InvalidRayQueryType(query));
12521252
}
12531253
},
@@ -1272,7 +1272,7 @@ impl super::Validator {
12721272
match resolver[operand] {
12731273
Ti::CooperativeMatrix { role, .. } if role == expected_role => {}
12741274
ref other => {
1275-
log::error!("{expected_role:?} operand type: {other:?}");
1275+
log::debug!("{expected_role:?} operand type: {other:?}");
12761276
return Err(ExpressionError::InvalidCooperativeOperand(a));
12771277
}
12781278
}

0 commit comments

Comments
 (0)