Skip to content

Commit ccc650f

Browse files
Tim-Evans-SeequentTim Evans
andauthored
Added missing aspect field in map_texture_copy_view. (gfx-rs#8445)
Co-authored-by: Tim Evans <[email protected]>
1 parent 80c4468 commit ccc650f

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ By @SupaMaggie70Incorporated in [#8206](https://github.com/gfx-rs/wgpu/pull/8206
138138
- Removed three features from `wgpu-hal` which did nothing useful: `"cargo-clippy"`, `"gpu-allocator"`, and `"rustc-hash"`. By @kpreid in [#8357](https://github.com/gfx-rs/wgpu/pull/8357).
139139
- `wgpu_types::PollError` now always implements the `Error` trait. By @kpreid in [#8384](https://github.com/gfx-rs/wgpu/pull/8384).
140140
- The texture subresources used by the color attachments of a render pass are no longer allowed to overlap when accessed via different texture views. By @andyleiserson in [#8402](https://github.com/gfx-rs/wgpu/pull/8402).
141+
- Fixed a bug where the texture aspect was not passed through when calling `copy_texture_to_buffer` in WebGPU, causing the copy to fail for depth/stencil textures. By @Tim-Evans-Seequent in [#8445](https://github.com/gfx-rs/wgpu/pull/8445).
141142

142143
#### DX12
143144

wgpu/src/backend/webgpu.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -632,6 +632,7 @@ fn map_texture_copy_view(
632632
let mapped = webgpu_sys::GpuTexelCopyTextureInfo::new(&texture.inner);
633633
mapped.set_mip_level(view.mip_level);
634634
mapped.set_origin(&map_origin_3d(view.origin));
635+
mapped.set_aspect(map_texture_aspect(view.aspect));
635636
mapped
636637
}
637638

0 commit comments

Comments
 (0)