FIXUP: ugh yet more lint expectations

Author: ErichDonGubler

naga/src/arena/handlevec.rs

@@ -34,7 +34,6 @@ impl<T, U> Default for HandleVec<T, U> {
     }
 }
 
-#[allow(dead_code)]
 impl<T, U> HandleVec<T, U> {
     pub(crate) const fn new() -> Self {
         Self {
@@ -66,7 +65,10 @@ impl<T, U> HandleVec<T, U> {
         assert_eq!(handle.index(), self.inner.len());
         self.inner.push(value);
     }
+}
 
+#[cfg_attr(not(any(glsl_out, spv_out, msl_out)), expect(dead_code))]
+impl<T, U> HandleVec<T, U> {
     pub(crate) fn get(&self, handle: Handle<T>) -> Option<&U> {
         self.inner.get(handle.index())
     }

naga/src/back/msl/writer.rs

@@ -1782,7 +1782,7 @@ impl<W: Write> Writer<W> {
         Ok(())
     }
 
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     fn put_possibly_const_expression<C, I, E>(
         &mut self,
         expr_handle: Handle<crate::Expression>,

naga/src/back/spv/block.rs

@@ -2987,7 +2987,7 @@ impl BlockContext<'_> {
     }
 
     /// Build the instructions for matrix - matrix column operations
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     fn write_matrix_matrix_column_op(
         &mut self,
         block: &mut Block,

naga/src/back/spv/helpers.rs

@@ -29,7 +29,7 @@ pub(super) fn str_bytes_to_words(bytes: &[u8]) -> Vec<Word> {
 }
 
 /// split a string into chunks and keep utf8 valid
-#[allow(unstable_name_collisions)]
+#[expect(unstable_name_collisions)]
 pub(super) fn string_to_byte_chunks(input: &str, limit: usize) -> Vec<&[u8]> {
     let mut offset: usize = 0;
     let mut start: usize = 0;

naga/src/back/spv/image.rs

@@ -719,7 +719,7 @@ impl BlockContext<'_> {
     /// Generate code for an `ImageLoad` expression.
     ///
     /// The arguments are the components of an `Expression::ImageLoad` variant.
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     pub(super) fn write_image_load(
         &mut self,
         result_type_id: Word,
@@ -799,7 +799,7 @@ impl BlockContext<'_> {
     /// Generate code for an `ImageSample` expression.
     ///
     /// The arguments are the components of an `Expression::ImageSample` variant.
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     pub(super) fn write_image_sample(
         &mut self,
         result_type_id: Word,

naga/src/back/spv/instructions.rs

@@ -778,7 +778,7 @@ impl super::Instruction {
     //
     //  Ray Query Instructions
     //
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     pub(super) fn ray_query_initialize(
         query: Word,
         acceleration_structure: Word,

naga/src/front/glsl/context.rs

@@ -503,7 +503,7 @@ impl<'a> Context<'a> {
                 vector = pointer;
             }
 
-            #[allow(clippy::needless_range_loop)]
+            #[expect(clippy::needless_range_loop)]
             for index in 0..size {
                 let dst = self.add_expression(
                     Expression::AccessIndex {

naga/src/front/glsl/functions.rs

@@ -207,7 +207,7 @@ impl Frontend {
         })
     }
 
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     fn matrix_one_arg(
         &mut self,
         ctx: &mut Context,
@@ -869,7 +869,7 @@ impl Frontend {
 
     /// Processes a function call argument that appears in place of an output
     /// parameter.
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     fn process_lhs_argument(
         &mut self,
         ctx: &mut Context,

naga/src/front/spv/image.rs

@@ -486,7 +486,7 @@ impl<I: Iterator<Item = u32>> super::Frontend<I> {
         Ok(())
     }
 
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     pub(super) fn parse_image_sample(
         &mut self,
         mut words_left: u16,

naga/src/front/spv/mod.rs

@@ -1091,7 +1091,7 @@ impl<I: Iterator<Item = u32>> Frontend<I> {
     /// A more complicated version of the binary op,
     /// where we force the operand to have the same type as the result.
     /// This is mostly needed for "i++" and "i--" coming from GLSL.
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     fn parse_expr_binary_op_sign_adjusted(
         &mut self,
         ctx: &mut BlockContext,
@@ -1169,7 +1169,7 @@ impl<I: Iterator<Item = u32>> Frontend<I> {
     /// A version of the binary op where one or both of the arguments might need to be casted to a
     /// specific integer kind (unsigned or signed), used for operations like OpINotEqual or
     /// OpUGreaterThan.
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     fn parse_expr_int_comparison(
         &mut self,
         ctx: &mut BlockContext,
@@ -1317,7 +1317,7 @@ impl<I: Iterator<Item = u32>> Frontend<I> {
         Ok(())
     }
 
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     fn insert_composite(
         &self,
         root_expr: Handle<crate::Expression>,
@@ -1441,7 +1441,7 @@ impl<I: Iterator<Item = u32>> Frontend<I> {
         Ok((p_lexp_handle, p_base_ty.handle))
     }
 
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     fn parse_atomic_expr_with_value(
         &mut self,
         inst: Instruction,