refactor(types)!: promote Features::SUBGROUPS to WebGPU

Author: ErichDonGubler

wgpu-types/src/features.rs

@@ -65,7 +65,8 @@ mod webgpu_impl {
     #[doc(hidden)]
     pub const WEBGPU_FEATURE_DUAL_SOURCE_BLENDING: u64 = 1 << 14;
 
-    // TODO: SUBGROUPS
+    #[doc(hidden)]
+    pub const WEBGPU_FEATURE_SUBGROUPS: u64 = 1 << 15;
 
     // TODO: TEXTURE_FORMATS_TIER1
 
@@ -76,7 +77,7 @@ mod webgpu_impl {
     // TODO: TEXTURE_COMPONENT_SWIZZLE
 
     #[doc(hidden)]
-    pub const WEBGPU_FEATURE_IMMEDIATES: u64 = 1 << 15;
+    pub const WEBGPU_FEATURE_IMMEDIATES: u64 = 1 << 16;
 }
 
 macro_rules! bitflags_array_impl {
@@ -1047,24 +1048,14 @@ bitflags_array! {
         ///
         /// This is a native only feature.
         const SHADER_INT64 = 1 << 37;
-        /// Allows compute and fragment shaders to use the subgroup operation
-        /// built-ins and perform subgroup operations (except barriers).
-        ///
-        /// Supported Platforms:
-        /// - Vulkan
-        /// - DX12
-        /// - Metal
-        ///
-        /// This is a native only feature.
-        const SUBGROUPS = 1 << 38;
         /// Allows vertex shaders to use the subgroup operation built-ins and
         /// perform subgroup operations (except barriers).
         ///
         /// Supported Platforms:
         /// - Vulkan
         ///
         /// This is a native only feature.
-        const SUBGROUPS_VERTEX = 1 << 39;
+        const SUBGROUPS_VERTEX = 1 << 38;
         /// Allows compute shaders to use the subgroup barrier.
         ///
         /// Requires [`Features::SUBGROUPS`]. Without it, enables nothing.
@@ -1074,7 +1065,7 @@ bitflags_array! {
         /// - Metal
         ///
         /// This is a native only feature.
-        const SUBGROUPS_BARRIER = 1 << 40;
+        const SUBGROUPS_BARRIER = 1 << 39;
         /// Allows the use of pipeline cache objects
         ///
         /// Supported platforms:
@@ -1083,7 +1074,7 @@ bitflags_array! {
         /// Unimplemented Platforms:
         /// - DX12
         /// - Metal
-        const PIPELINE_CACHE = 1 << 41;
+        const PIPELINE_CACHE = 1 << 40;
         /// Allows shaders to use i64 and u64 atomic min and max.
         ///
         /// Supported platforms:
@@ -1092,15 +1083,15 @@ bitflags_array! {
         /// - Metal (with MSL 2.4+)
         ///
         /// This is a native only feature.
-        const SHADER_INT64_ATOMIC_MIN_MAX = 1 << 42;
+        const SHADER_INT64_ATOMIC_MIN_MAX = 1 << 41;
         /// Allows shaders to use all i64 and u64 atomic operations.
         ///
         /// Supported platforms:
         /// - Vulkan (with VK_KHR_shader_atomic_int64)
         /// - DX12 (with SM 6.6+)
         ///
         /// This is a native only feature.
-        const SHADER_INT64_ATOMIC_ALL_OPS = 1 << 43;
+        const SHADER_INT64_ATOMIC_ALL_OPS = 1 << 42;
         /// Allows using the [VK_GOOGLE_display_timing] Vulkan extension.
         ///
         /// This is used for frame pacing to reduce latency, and is generally only available on Android.
@@ -1116,7 +1107,7 @@ bitflags_array! {
         ///
         /// [VK_GOOGLE_display_timing]: https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_GOOGLE_display_timing.html
         #[doc = link_to_wgpu_docs!(["`Surface::as_hal()`"]: "struct.Surface.html#method.as_hal")]
-        const VULKAN_GOOGLE_DISPLAY_TIMING = 1 << 44;
+        const VULKAN_GOOGLE_DISPLAY_TIMING = 1 << 43;
 
         /// Allows using the [VK_KHR_external_memory_win32] Vulkan extension.
         ///
@@ -1126,7 +1117,7 @@ bitflags_array! {
         /// This is a native only feature.
         ///
         /// [VK_KHR_external_memory_win32]: https://registry.khronos.org/vulkan/specs/latest/man/html/VK_KHR_external_memory_win32.html
-        const VULKAN_EXTERNAL_MEMORY_WIN32 = 1 << 45;
+        const VULKAN_EXTERNAL_MEMORY_WIN32 = 1 << 44;
 
         /// Enables R64Uint image atomic min and max.
         ///
@@ -1136,7 +1127,7 @@ bitflags_array! {
         /// - Metal (with MSL 3.1+)
         ///
         /// This is a native only feature.
-        const TEXTURE_INT64_ATOMIC = 1 << 46;
+        const TEXTURE_INT64_ATOMIC = 1 << 45;
 
         /// Allows uniform buffers to be bound as binding arrays.
         ///
@@ -1153,7 +1144,7 @@ bitflags_array! {
         /// - Vulkan 1.2+ (or VK_EXT_descriptor_indexing)'s `shaderUniformBufferArrayNonUniformIndexing` feature)
         ///
         /// This is a native only feature.
-        const UNIFORM_BUFFER_BINDING_ARRAYS = 1 << 47;
+        const UNIFORM_BUFFER_BINDING_ARRAYS = 1 << 46;
 
         /// Enables mesh shaders and task shaders in mesh shader pipelines. This extension does NOT imply support for
         /// compiling mesh shaders at runtime.
@@ -1172,7 +1163,7 @@ bitflags_array! {
         /// [this Mesa issue.](https://gitlab.freedesktop.org/mesa/mesa/-/issues/14376)
         ///
         /// This is a native only feature.
-        const EXPERIMENTAL_MESH_SHADER = 1 << 48;
+        const EXPERIMENTAL_MESH_SHADER = 1 << 47;
 
         /// ***THIS IS EXPERIMENTAL:*** Features enabled by this may have
         /// major bugs in them and are expected to be subject to breaking changes, suggestions
@@ -1187,7 +1178,7 @@ bitflags_array! {
         /// This is a native only feature
         ///
         /// [`AccelerationStructureFlags::ALLOW_RAY_HIT_VERTEX_RETURN`]: super::AccelerationStructureFlags::ALLOW_RAY_HIT_VERTEX_RETURN
-        const EXPERIMENTAL_RAY_HIT_VERTEX_RETURN = 1 << 49;
+        const EXPERIMENTAL_RAY_HIT_VERTEX_RETURN = 1 << 48;
 
         /// Enables multiview in mesh shader pipelines
         ///
@@ -1199,7 +1190,7 @@ bitflags_array! {
         /// - Metal
         ///
         /// This is a native only feature.
-        const EXPERIMENTAL_MESH_SHADER_MULTIVIEW = 1 << 50;
+        const EXPERIMENTAL_MESH_SHADER_MULTIVIEW = 1 << 49;
 
         /// Allows usage of additional vertex formats in [BlasTriangleGeometrySizeDescriptor::vertex_format]
         ///
@@ -1208,7 +1199,7 @@ bitflags_array! {
         /// - DX12
         ///
         /// [BlasTriangleGeometrySizeDescriptor::vertex_format]: super::BlasTriangleGeometrySizeDescriptor
-        const EXTENDED_ACCELERATION_STRUCTURE_VERTEX_FORMATS = 1 << 51;
+        const EXTENDED_ACCELERATION_STRUCTURE_VERTEX_FORMATS = 1 << 50;
 
         /// Enables creating shaders from passthrough with reflection info (unsafe)
         ///
@@ -1226,7 +1217,7 @@ bitflags_array! {
         /// [this comment](https://github.com/gfx-rs/wgpu/issues/3103#issuecomment-2833058367).
         ///
         #[doc = link_to_wgpu_docs!(["`Device::create_shader_module_passthrough`"]: "struct.Device.html#method.create_shader_module_passthrough")]
-        const EXPERIMENTAL_PASSTHROUGH_SHADERS = 1 << 52;
+        const EXPERIMENTAL_PASSTHROUGH_SHADERS = 1 << 51;
 
         /// Enables shader barycentric coordinates.
         ///
@@ -1236,7 +1227,7 @@ bitflags_array! {
         /// - Metal (with MSL 2.2+)
         ///
         /// This is a native only feature.
-        const SHADER_BARYCENTRICS = 1 << 53;
+        const SHADER_BARYCENTRICS = 1 << 52;
 
         /// Enables using multiview where not all texture array layers are rendered to in a single render pass/render pipeline. Making
         /// use of this feature also requires enabling `Features::MULTIVIEW`.
@@ -1247,7 +1238,7 @@ bitflags_array! {
         ///
         ///
         /// While metal supports this in theory, the behavior of `view_index` differs from vulkan and dx12 so the feature isn't exposed.
-        const SELECTIVE_MULTIVIEW = 1 << 54;
+        const SELECTIVE_MULTIVIEW = 1 << 53;
 
         /// Enables the use of point-primitive outputs from mesh shaders. Making use of this feature also requires enabling
         /// `Features::EXPERIMENTAL_MESH_SHADER`.
@@ -1257,7 +1248,7 @@ bitflags_array! {
         /// - Metal
         ///
         /// This is a native only feature.
-        const EXPERIMENTAL_MESH_SHADER_POINTS = 1 << 55;
+        const EXPERIMENTAL_MESH_SHADER_POINTS = 1 << 54;
 
         /// Enables creating texture arrays that are also multisampled.
         ///
@@ -1266,7 +1257,7 @@ bitflags_array! {
         ///
         /// Supported platforms:
         /// - Vulkan (except VK_KHR_portability_subset if multisampleArrayImage is not available)
-        const MULTISAMPLE_ARRAY = 1 << 56;
+        const MULTISAMPLE_ARRAY = 1 << 55;
 
         /// Enables cooperative matrix operations (also known as tensor cores on NVIDIA GPUs
         /// or simdgroup matrix operations on Apple GPUs).
@@ -1285,15 +1276,15 @@ bitflags_array! {
         /// - Vulkan (with [VK_KHR_cooperative_matrix](https://registry.khronos.org/vulkan/specs/latest/man/html/VK_KHR_cooperative_matrix.html), if 8x8 f32 is supported)
         ///
         /// This is a native only feature.
-        const EXPERIMENTAL_COOPERATIVE_MATRIX = 1 << 57;
+        const EXPERIMENTAL_COOPERATIVE_MATRIX = 1 << 56;
 
         /// Enables shader per-vertex attributes.
         ///
         /// Supported platforms:
         /// - Vulkan (with VK_KHR_fragment_shader_barycentric)
         ///
         /// This is a native only feature.
-        const SHADER_PER_VERTEX = 1 << 58;
+        const SHADER_PER_VERTEX = 1 << 57;
     }
 
     /// Features that are not guaranteed to be supported.
@@ -1544,6 +1535,17 @@ bitflags_array! {
         /// This is a web and native feature.
         const DUAL_SOURCE_BLENDING = WEBGPU_FEATURE_DUAL_SOURCE_BLENDING;
 
+        /// Allows compute and fragment shaders to use the subgroup operation
+        /// built-ins and perform subgroup operations (except barriers).
+        ///
+        /// Supported Platforms:
+        /// - Vulkan
+        /// - DX12
+        /// - Metal
+        ///
+        /// This is a web and native feature.
+        const SUBGROUPS = WEBGPU_FEATURE_SUBGROUPS;
+
         /// Allows the use of immediate data: small, fast bits of memory that can be updated
         /// inside a [`RenderPass`].
         ///