WIP: feat(naga): allow u32 for sample index arg. of texture loads

ErichDonGubler · ErichDonGubler · commit b19427c43d12 · 2025-04-24T13:15:01.000-04:00
diff --git a/naga/src/valid/expression.rs b/naga/src/valid/expression.rs
@@ -660,7 +660,7 @@ impl super::Validator {
                 match (sample, class.is_multisampled()) {
                     (None, false) => {}
                     (Some(sample), true) => {
-                        if resolver[sample].scalar_kind() != Some(Sk::Sint) {
+                        if !matches!(resolver[sample].scalar_kind(), Some(Sk::Sint | Sk::Uint)) {
                             return Err(ExpressionError::InvalidImageOtherIndexType(sample));
                         }
                     }

Original file line number	Diff line number	Diff line change
`@@ -660,7 +660,7 @@ impl super::Validator {`
`660`	`660`	`match (sample, class.is_multisampled()) {`
`661`	`661`	`(None, false) => {}`
`662`	`662`	`(Some(sample), true) => {`
`663`		`- if resolver[sample].scalar_kind() != Some(Sk::Sint) {`
	`663`	`+ if !matches!(resolver[sample].scalar_kind(), Some(Sk::Sint \| Sk::Uint)) {`
`664`	`664`	`return Err(ExpressionError::InvalidImageOtherIndexType(sample));`
`665`	`665`	`}`
`666`	`666`	`}`