Split MipmapFilterMode from FilterMode (gfx-rs#8314)

Author: sagudev

CHANGELOG.md

@@ -54,6 +54,19 @@ This is a breaking change
 
 By @R-Cramer4 in [#8230](https://github.com/gfx-rs/wgpu/pull/8230)
 
+#### `MipmapFilterMode` is split from `FilterMode`
+
+This is a breaking change that aligns wgpu with spec.
+
+```diff
+SamplerDescriptor {
+...
+-     mipmap_filter: FilterMode::Nearest
++     mipmap_filter: MipmapFilterMode::Nearest
+...
+}
+```
+
 ## v27.0.2 (2025-10-03)
 
 ### Bug Fixes

deno_webgpu/sampler.rs

@@ -66,8 +66,8 @@ pub(super) struct GPUSamplerDescriptor {
   pub mag_filter: GPUFilterMode,
   #[webidl(default = GPUFilterMode::Nearest)]
   pub min_filter: GPUFilterMode,
-  #[webidl(default = GPUFilterMode::Nearest)]
-  pub mipmap_filter: GPUFilterMode,
+  #[webidl(default = GPUMipmapFilterMode::Nearest)]
+  pub mipmap_filter: GPUMipmapFilterMode,
 
   #[webidl(default = 0.0)]
   pub lod_min_clamp: f32,
@@ -99,7 +99,6 @@ impl From<GPUAddressMode> for wgpu_types::AddressMode {
   }
 }
 
-// Same as GPUMipmapFilterMode
 #[derive(WebIDL)]
 #[webidl(enum)]
 pub(crate) enum GPUFilterMode {
@@ -116,6 +115,22 @@ impl From<GPUFilterMode> for wgpu_types::FilterMode {
   }
 }
 
+#[derive(WebIDL)]
+#[webidl(enum)]
+pub(crate) enum GPUMipmapFilterMode {
+  Nearest,
+  Linear,
+}
+
+impl From<GPUMipmapFilterMode> for wgpu_types::MipmapFilterMode {
+  fn from(value: GPUMipmapFilterMode) -> Self {
+    match value {
+      GPUMipmapFilterMode::Nearest => Self::Nearest,
+      GPUMipmapFilterMode::Linear => Self::Linear,
+    }
+  }
+}
+
 #[derive(WebIDL)]
 #[webidl(enum)]
 pub(crate) enum GPUCompareFunction {

examples/features/src/bunnymark/mod.rs

@@ -278,7 +278,7 @@ impl crate::framework::Example for Example {
             address_mode_w: wgpu::AddressMode::ClampToEdge,
             mag_filter: wgpu::FilterMode::Linear,
             min_filter: wgpu::FilterMode::Nearest,
-            mipmap_filter: wgpu::FilterMode::Nearest,
+            mipmap_filter: wgpu::MipmapFilterMode::Nearest,
             ..Default::default()
         });
 

examples/features/src/mipmap/mod.rs

@@ -117,7 +117,7 @@ impl Example {
             address_mode_w: wgpu::AddressMode::ClampToEdge,
             mag_filter: wgpu::FilterMode::Linear,
             min_filter: wgpu::FilterMode::Linear,
-            mipmap_filter: wgpu::FilterMode::Nearest,
+            mipmap_filter: wgpu::MipmapFilterMode::Nearest,
             ..Default::default()
         });
 
@@ -268,7 +268,7 @@ impl crate::framework::Example for Example {
             address_mode_w: wgpu::AddressMode::Repeat,
             mag_filter: wgpu::FilterMode::Linear,
             min_filter: wgpu::FilterMode::Linear,
-            mipmap_filter: wgpu::FilterMode::Linear,
+            mipmap_filter: wgpu::MipmapFilterMode::Linear,
             ..Default::default()
         });
         let mx_total = Self::generate_matrix(config.width as f32 / config.height as f32);

examples/features/src/multiple_render_targets/mod.rs

@@ -121,7 +121,7 @@ impl MultiTargetRenderer {
             address_mode_w: wgpu::AddressMode::Repeat,
             mag_filter: wgpu::FilterMode::Nearest,
             min_filter: wgpu::FilterMode::Nearest,
-            mipmap_filter: wgpu::FilterMode::Nearest,
+            mipmap_filter: wgpu::MipmapFilterMode::Nearest,
             ..Default::default()
         });
 
@@ -240,7 +240,7 @@ impl TargetRenderer {
             address_mode_w: wgpu::AddressMode::Repeat,
             mag_filter: wgpu::FilterMode::Nearest,
             min_filter: wgpu::FilterMode::Nearest,
-            mipmap_filter: wgpu::FilterMode::Nearest,
+            mipmap_filter: wgpu::MipmapFilterMode::Nearest,
             ..Default::default()
         });
 

examples/features/src/ray_cube_compute/mod.rs

@@ -200,7 +200,7 @@ impl crate::framework::Example for Example {
             address_mode_w: wgpu::AddressMode::ClampToEdge,
             mag_filter: wgpu::FilterMode::Linear,
             min_filter: wgpu::FilterMode::Linear,
-            mipmap_filter: wgpu::FilterMode::Nearest,
+            mipmap_filter: wgpu::MipmapFilterMode::Nearest,
             ..Default::default()
         });
 

examples/features/src/ray_cube_normals/mod.rs

@@ -189,7 +189,7 @@ impl crate::framework::Example for Example {
             address_mode_w: wgpu::AddressMode::ClampToEdge,
             mag_filter: wgpu::FilterMode::Linear,
             min_filter: wgpu::FilterMode::Linear,
-            mipmap_filter: wgpu::FilterMode::Nearest,
+            mipmap_filter: wgpu::MipmapFilterMode::Nearest,
             ..Default::default()
         });
 

examples/features/src/ray_traced_triangle/mod.rs

@@ -257,7 +257,7 @@ impl crate::framework::Example for Example {
             address_mode_w: Default::default(),
             mag_filter: wgpu::FilterMode::Nearest,
             min_filter: wgpu::FilterMode::Nearest,
-            mipmap_filter: wgpu::FilterMode::Nearest,
+            mipmap_filter: wgpu::MipmapFilterMode::Nearest,
             lod_min_clamp: 1.0,
             lod_max_clamp: 1.0,
             compare: None,

examples/features/src/shadow/mod.rs

@@ -366,7 +366,7 @@ impl crate::framework::Example for Example {
             address_mode_w: wgpu::AddressMode::ClampToEdge,
             mag_filter: wgpu::FilterMode::Linear,
             min_filter: wgpu::FilterMode::Linear,
-            mipmap_filter: wgpu::FilterMode::Nearest,
+            mipmap_filter: wgpu::MipmapFilterMode::Nearest,
             compare: Some(wgpu::CompareFunction::LessEqual),
             ..Default::default()
         });

examples/features/src/skybox/mod.rs

@@ -263,7 +263,7 @@ impl crate::framework::Example for Example {
             address_mode_w: wgpu::AddressMode::ClampToEdge,
             mag_filter: wgpu::FilterMode::Linear,
             min_filter: wgpu::FilterMode::Linear,
-            mipmap_filter: wgpu::FilterMode::Linear,
+            mipmap_filter: wgpu::MipmapFilterMode::Linear,
             ..Default::default()
         });