TODO: check override-resolved dimensions for maxWorkGroupSize* and maxInvocationsPerWorkgroup limits

CTS test that's breaking: `webgpu:api,validation,compute_pipeline:overrides,workgroup_size,limits:*`

From [Andy's comment]:

> The issue with the invocation size limits is that they need to be
> validated _after_ overrides have been resolved. We resolve overrides
> within the hal `create_compute_pipeline` function, but we validate the
> size in core's `create_compute_pipeline` function before calling hal.
> 
> Besides the order that things happen, we also need to be careful that
> we validate against the final, override-resolved version of the entry
> point, rather than using `shader_module.interface.entry_points` if that
> can be stale.

[Andy's comment]: gfx-rs#8946 (comment)

Author: ErichDonGubler

CHANGELOG.md

@@ -51,18 +51,25 @@ Bottom level categories:
 - Fix missing dependency feature activations when building wgpu-hal with gles/dx12 in isolation. By @wumpf in [#9325](https://github.com/gfx-rs/wgpu/pull/9325)
 - Make `wgpu_types::texture::format::TextureChannel` accessible as `wgpu::TextureChannel`. By @TornaxO7 in [#9394](https://github.com/gfx-rs/wgpu/pull/9349).
 - Add support for `per_vertex` in Metal and DX12, as well as some validation for `per_vertex`, and a new enable extension, `wgpu_per_vertex`. By @inner-daemons in [#9219](https://github.com/gfx-rs/wgpu/pull/9219).
+- Add `ComputePass` version of `CommandEncoder::transition_resources` that allows intra-pass transitions. By @wingertge in [#9371](https://github.com/gfx-rs/wgpu/pull/9371).
 
 #### Metal
 
 - Unconditionally enable `Features::CLIP_DISTANCES`. By @ErichDonGubler in [#9270](https://github.com/gfx-rs/wgpu/pull/9270).
 - Added full support for mesh shaders, including in WGSL shaders. By @inner-daemons in [#8739](https://github.com/gfx-rs/wgpu/pull/8739).
+- Fixed structure field names incorrectly ignoring reserved keywords in the Metal (MSL) backend. By @39ali [#9379](https://github.com/gfx-rs/wgpu/pull/9379).
+
+#### GLES
+
+- Added support for GLSL passthrough. By @inner-daemons in [#9064](https://github.com/gfx-rs/wgpu/pull/9064).
 
 #### DX12
 
 - Added support for mesh shaders in naga's HLSL writer, completing DX12 support for mesh shaders. By @inner-daemons in [#8752](https://github.com/gfx-rs/wgpu/pull/8752).
 
 #### Vulkan
 
+- Add `vulkan::Device::texture_from_dmabuf_fd()` for importing DMA-buf textures on Linux, with `VULKAN_EXTERNAL_MEMORY_FD` and `VULKAN_EXTERNAL_MEMORY_DMA_BUF` feature flags. By @TODO in [#TODO](https://github.com/gfx-rs/wgpu/pull/TODO).
 - Add support for RawWindowHandle::Drm on unix. By @rectalogic in [#9182](https://github.com/gfx-rs/wgpu/pull/9182).
 
 ### Changes
@@ -73,6 +80,9 @@ Bottom level categories:
 - Added more granular limits for mesh shaders. By @inner-daemons in [#8739](https://github.com/gfx-rs/wgpu/pull/8739).
 - Added new `InvalidWorkgroupSizeError`, which is now used by `DrawError::InvalidGroupSize` and `StageError::InvalidWorkgroupSize`. By @andyleiserson in [#9357](https://github.com/gfx-rs/wgpu/pull/9357).
 - Zero-size `Queue::write_buffer` now returns an error if the offset is invalid or the buffer lacks `COPY_DST`. By @39ali in [#9374](https://github.com/gfx-rs/wgpu/pull/9374).
+- `Buffer::get_mapped_range` and variants now return `Result<_, MapRangeError>>` instead of panicking, in line with WebGPU spec. By @atlv24 in [#9281](https://github.com/gfx-rs/wgpu/pull/9281).
+- Passthrough shaders now require a list of entry points when being created. by @inner-daemons in [#9064](https://github.com/gfx-rs/wgpu/pull/9064).
+- BREAKING: The `dispatch` and `dispatch_indirect` methods on pass and bundle encoders have been renamed to `dispatch_workgroups` and `dispatch_workgroups_indirect`, respectively, to match the WebGPU spec. By @ErichDonGubler in [#9362](https://github.com/gfx-rs/wgpu/pull/9362).
 
 #### Validation
 
@@ -90,12 +100,12 @@ Bottom level categories:
 
 #### naga
 
+- Fixed atomic load and store operations being incorrectly generated as non-atomic memory accesses in GLSL and HLSL. By @CldStlkr in [#9242](https://github.com/gfx-rs/wgpu/pull/9242).
 - Fixed overflow detection and argument domain validation for `acosh`, `length`, `normalize`, and `pow` in constant evaluation. By @ecoricemon in [#9249](https://github.com/gfx-rs/wgpu/pull/9249).
 - Naga no longer allows derivative operations on `f16`. WGSL does not currently allow this, although [it may be added in the future](https://github.com/gpuweb/gpuweb/issues/5482). By @andyleiserson in [#9154](https://github.com/gfx-rs/wgpu/pull/9154).
 - Disallow direct access to atomic variables in WGSL front-end (e.g. `let x = myAtomic;`). By @ecoricemon in [#9262](https://github.com/gfx-rs/wgpu/pull/9262).
 - Fixed handling of unterminated block comments. By @BKDaugherty in [#9356](https://github.com/gfx-rs/wgpu/pull/9356).
 - Enforce that `@must_use` appear only on function declarations. By @dnsn021 in [#9367](https://github.com/gfx-rs/wgpu/pull/9367).
-- Fix typo in `naga::back::msl::Error::UnsupportedWritable*` variant names. By @ErichDonGubler in [#9376](https://github.com/gfx-rs/wgpu/pull/9376).
 
 #### dx12
 

examples/features/src/big_compute_buffers/mod.rs

@@ -85,7 +85,7 @@ pub async fn execute_gpu_inner(
     let mut data = Vec::new();
     for staging_buffer in &staging_buffers {
         let slice = staging_buffer.slice(..);
-        let mapped = slice.get_mapped_range();
+        let mapped = slice.get_mapped_range().unwrap();
         let chunk: Vec<f32> = bytemuck::allocation::pod_collect_to_vec(&mapped);
         data.extend_from_slice(&chunk);
         drop(mapped);

examples/features/src/cooperative_matrix/mod.rs

@@ -411,7 +411,7 @@ async fn execute(
         .expect("Channel receive failed")
         .expect("Buffer mapping failed");
 
-    let data = buffer_slice.get_mapped_range();
+    let data = buffer_slice.get_mapped_range().unwrap();
 
     // Convert result back to f32 for comparison
     let result: Vec<f32> = if use_f16 {

examples/features/src/framework.rs

@@ -744,7 +744,7 @@ impl<E: Example + wgpu::WasmNotSendSync> From<ExampleTestParams<E>>
                 ctx.async_poll(wgpu::PollType::wait_indefinitely())
                     .await
                     .unwrap();
-                let bytes = dst_buffer_slice.get_mapped_range().to_vec();
+                let bytes = dst_buffer_slice.get_mapped_range().unwrap().to_vec();
 
                 wgpu_test::image::compare_image_output(
                     dbg!(env!("CARGO_MANIFEST_DIR").to_string() + "/../../" + params.image_path),

examples/features/src/hello_synchronization/mod.rs

@@ -185,7 +185,7 @@ async fn get_data<T: bytemuck::Pod>(
     device.poll(wgpu::PollType::wait_indefinitely()).unwrap();
     receiver.recv_async().await.unwrap().unwrap();
     let data: Vec<T> =
-        bytemuck::allocation::pod_collect_to_vec(&buffer_slice.get_mapped_range()[..]);
+        bytemuck::allocation::pod_collect_to_vec(&buffer_slice.get_mapped_range().unwrap()[..]);
     output.copy_from_slice(&data);
     staging_buffer.unmap();
 }

examples/features/src/hello_workgroups/mod.rs

@@ -174,7 +174,7 @@ async fn get_data<T: bytemuck::Pod>(
     device.poll(wgpu::PollType::wait_indefinitely()).unwrap();
     receiver.recv_async().await.unwrap().unwrap();
     let data: Vec<T> =
-        bytemuck::allocation::pod_collect_to_vec(&buffer_slice.get_mapped_range()[..]);
+        bytemuck::allocation::pod_collect_to_vec(&buffer_slice.get_mapped_range().unwrap()[..]);
     output.copy_from_slice(&data);
     staging_buffer.unmap();
 }

examples/features/src/mesh_shader/mod.rs

@@ -1,38 +1,3 @@
-// Same as in mesh shader tests
-fn compile_wgsl(device: &wgpu::Device) -> wgpu::ShaderModule {
-    // Workgroup memory zero initialization can be expensive for mesh shaders
-    unsafe {
-        device.create_shader_module_trusted(
-            wgpu::ShaderModuleDescriptor {
-                label: None,
-                source: wgpu::ShaderSource::Wgsl(include_str!("shader.wgsl").into()),
-            },
-            wgpu::ShaderRuntimeChecks::unchecked(),
-        )
-    }
-}
-
-struct Shaders {
-    ts: wgpu::ShaderModule,
-    ms: wgpu::ShaderModule,
-    fs: wgpu::ShaderModule,
-    ts_name: &'static str,
-    ms_name: &'static str,
-    fs_name: &'static str,
-}
-
-fn get_shaders(device: &wgpu::Device) -> Shaders {
-    let compiled = compile_wgsl(device);
-    Shaders {
-        ts: compiled.clone(),
-        ms: compiled.clone(),
-        fs: compiled.clone(),
-        ts_name: "ts_main",
-        ms_name: "ms_main",
-        fs_name: "fs_main",
-    }
-}
-
 pub struct Example {
     pipeline: wgpu::RenderPipeline,
 }
@@ -43,14 +8,7 @@ impl crate::framework::Example for Example {
         device: &wgpu::Device,
         _queue: &wgpu::Queue,
     ) -> Self {
-        let Shaders {
-            ts,
-            ms,
-            fs,
-            ts_name,
-            ms_name,
-            fs_name,
-        } = get_shaders(device);
+        let shader = device.create_shader_module(wgpu::include_wgsl!("shader.wgsl"));
         let pipeline_layout = device.create_pipeline_layout(&wgpu::PipelineLayoutDescriptor {
             label: None,
             bind_group_layouts: &[],
@@ -60,18 +18,18 @@ impl crate::framework::Example for Example {
             label: None,
             layout: Some(&pipeline_layout),
             task: Some(wgpu::TaskState {
-                module: &ts,
-                entry_point: Some(ts_name),
+                module: &shader,
+                entry_point: Some("ts_main"),
                 compilation_options: Default::default(),
             }),
             mesh: wgpu::MeshState {
-                module: &ms,
-                entry_point: Some(ms_name),
+                module: &shader,
+                entry_point: Some("ms_main"),
                 compilation_options: Default::default(),
             },
             fragment: Some(wgpu::FragmentState {
-                module: &fs,
-                entry_point: Some(fs_name),
+                module: &shader,
+                entry_point: Some("fs_main"),
                 compilation_options: Default::default(),
                 targets: &[Some(config.view_formats[0].into())],
             }),

examples/features/src/mipmap/mod.rs

@@ -417,11 +417,13 @@ impl crate::framework::Example for Example {
             let timestamp_view = query_sets
                 .mapping_buffer
                 .slice(..size_of::<TimestampQueries>() as wgpu::BufferAddress)
-                .get_mapped_range();
+                .get_mapped_range()
+                .unwrap();
             let pipeline_stats_view = query_sets
                 .mapping_buffer
                 .slice(pipeline_statistics_offset()..)
-                .get_mapped_range();
+                .get_mapped_range()
+                .unwrap();
             // Convert the raw data into a useful structure
             let timestamp_data: &TimestampQueries = bytemuck::from_bytes(&timestamp_view);
             let pipeline_stats_data: &PipelineStatisticsQueries =

examples/features/src/ray_cube_compute/mod.rs

@@ -471,7 +471,7 @@ pub static TEST: crate::framework::ExampleTestParams = crate::framework::Example
     optional_features: wgpu::Features::default(),
     base_test_parameters: wgpu_test::TestParameters::default()
         // https://github.com/gfx-rs/wgpu/issues/9100
-        .expect_fail(wgpu_test::FailureCase::backend(wgpu::Backends::METAL)),
+        .disable_mtl_shader_validation(),
     comparisons: &[wgpu_test::ComparisonType::Mean(0.02)],
     _phantom: std::marker::PhantomData::<Example>,
 };

examples/features/src/ray_cube_fragment/mod.rs

@@ -357,7 +357,7 @@ pub static TEST: crate::framework::ExampleTestParams = crate::framework::Example
     optional_features: wgpu::Features::default(),
     base_test_parameters: wgpu_test::TestParameters::default()
         // https://github.com/gfx-rs/wgpu/issues/9100
-        .expect_fail(wgpu_test::FailureCase::backend(wgpu::Backends::METAL)),
+        .disable_mtl_shader_validation(),
     comparisons: &[wgpu_test::ComparisonType::Mean(0.02)],
     _phantom: std::marker::PhantomData::<Example>,
 };