WIP: diag(naga): use entire call span for ExpressionErrors from Calls

ErichDonGubler · ErichDonGubler · commit 7f71826f6fcb · 2025-04-18T08:43:48.000-04:00
TODO: Any undesirable effects here?
diff --git a/naga/src/front/wgsl/lower/mod.rs b/naga/src/front/wgsl/lower/mod.rs
@@ -2423,7 +2423,6 @@ impl<'source, 'temp> Lowerer<'source, 'temp> {
                 Ok(result)
             }
             None => {
-                let span = function_span;
                 let expr = if let Some(fun) = conv::map_relational_fun(function.name) {
                     let mut args = ctx.prepare_args(arguments, 1, span);
                     let argument = self.expression(args.next()?, ctx)?;

Original file line number	Diff line number	Diff line change
`@@ -2423,7 +2423,6 @@ impl<'source, 'temp> Lowerer<'source, 'temp> {`
`2423`	`2423`	`Ok(result)`
`2424`	`2424`	`}`
`2425`	`2425`	`None => {`
`2426`		`- let span = function_span;`
`2427`	`2426`	`let expr = if let Some(fun) = conv::map_relational_fun(function.name) {`
`2428`	`2427`	`let mut args = ctx.prepare_args(arguments, 1, span);`
`2429`	`2428`	`let argument = self.expression(args.next()?, ctx)?;`