Skip to content

Commit 63d6c34

Browse files
jimblandyteoxoy
authored andcommitted
[naga wgsl-in] Flatten control flow for clarity.
Adjust some methods of `TemplateListIter` to ensure that the typical complete control flow through the function follows the outermost nesting level.
1 parent 81a1e8d commit 63d6c34

1 file changed

Lines changed: 17 additions & 17 deletions

File tree

naga/src/front/wgsl/lower/template_list.rs

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -117,16 +117,16 @@ impl<'iter, 'source> TemplateListIter<'iter, 'source> {
117117
&mut self,
118118
ctx: &ExpressionContext<'source, '_, '_>,
119119
) -> Result<'source, Option<ir::AddressSpace>> {
120-
if let Some(expr) = self.template_list.next() {
121-
let (enumerant, span) = ctx.enumerant(*expr)?;
122-
Ok(Some(conv::map_address_space(
123-
enumerant,
124-
span,
125-
&ctx.enable_extensions,
126-
)?))
127-
} else {
128-
Ok(None)
129-
}
120+
let Some(expr) = self.template_list.next() else {
121+
return Ok(None);
122+
};
123+
124+
let (enumerant, span) = ctx.enumerant(*expr)?;
125+
Ok(Some(conv::map_address_space(
126+
enumerant,
127+
span,
128+
&ctx.enable_extensions,
129+
)?))
130130
}
131131

132132
pub fn access_mode(
@@ -179,13 +179,13 @@ impl<'iter, 'source> TemplateListIter<'iter, 'source> {
179179
&mut self,
180180
ctx: &ExpressionContext<'source, '_, '_>,
181181
) -> Result<'source, bool> {
182-
if let Some(expr) = self.template_list.next() {
183-
let (enumerant, span) = ctx.enumerant(*expr)?;
184-
conv::map_ray_flag(&ctx.enable_extensions, enumerant, span)?;
185-
Ok(true)
186-
} else {
187-
Ok(false)
188-
}
182+
let Some(expr) = self.template_list.next() else {
183+
return Ok(false);
184+
};
185+
186+
let (enumerant, span) = ctx.enumerant(*expr)?;
187+
conv::map_ray_flag(&ctx.enable_extensions, enumerant, span)?;
188+
Ok(true)
189189
}
190190

191191
pub fn cooperative_role(

0 commit comments

Comments
 (0)