WIP: snapshot tests for fully implemented select

Author: ErichDonGubler

naga/tests/in/wgsl/select.wgsl

@@ -0,0 +1,32 @@
+const_assert select(0xdeadbeef, 42f, false) == 0xdeadbeef;
+const_assert select(0xdeadbeefu, 42, false) == 0xdeadbeefu;
+const_assert select(0xdeadi, 42, false) == 0xdeadi;
+
+const_assert select(42f, 9001, true) == 9001;
+const_assert select(42f, 9001, true) == 9001f;
+const_assert select(42, 9001i, true) == 9001;
+const_assert select(42, 9001u, true) == 9001;
+
+const_assert !select(false, true, false);
+const_assert select(false, true, true);
+const_assert select(true, false, false);
+const_assert !select(true, false, true);
+
+const_assert all(select(vec2(2f), vec2(), true) == vec2(0));
+const_assert all(select(vec2(1), vec2(2f), false) == vec2(1));
+const_assert all(select(vec2(1), vec2(2f), false) == vec2(1));
+const_assert all(select(vec2(1), vec2(2f), vec2(false, false)) == vec2(1));
+const_assert all(select(vec2(1), vec2(2f), vec2(true)) == vec2(2));
+const_assert all(select(vec2(1), vec2(2f), vec2(true)) == vec2(2));
+const_assert all(select(vec2(1), vec2(2f), vec2(true, false)) == vec2(2, 1));
+
+const_assert all(select(vec3(1), vec3(2f), vec3(true)) == vec3(2));
+const_assert all(select(vec4(1), vec4(2f), vec4(true)) == vec4(2));
+
+@compute @workgroup_size(1, 1)
+fn main() {
+    _ = select(1, 2f, false);
+
+    var x0 = vec2(1, 2);
+    var i1: vec2<f32> = select(vec2<f32>(1., 0.), vec2<f32>(0., 1.), (x0.x < x0.y));
+}

naga/tests/naga/validation.rs

@@ -670,26 +670,6 @@ error: Function [1] 'main' is invalid
   │  \n  = Call to [0] is invalid
   = Requires 1 arguments, but 0 are provided
 
-",
-        ),
-        (
-            "\
-@compute @workgroup_size(1, 1)
-fn main() {
-    // Bad: `9001` isn't a `bool`.
-    _ = select(1, 2, 9001);
-}
-",
-            "\
-error: Entry point main at Compute is invalid
-  ┌─ wgsl:4:9
-  │
-4 │     _ = select(1, 2, 9001);
-  │         ^^^^^^ naga::ir::Expression [3]
-  │
-  = Expression [3] is invalid
-  = Expected selection condition to be a boolean value, got Scalar(Scalar { kind: Sint, width: 4 })
-
 ",
         ),
         (

naga/tests/naga/wgsl_errors.rs

@@ -2081,6 +2081,47 @@ fn select() {
         )
         if name.starts_with("select_")
     }
+
+    let snapshots = [
+        (
+            "\
+@compute @workgroup_size(1, 1)
+fn main() {
+    // Bad: `9001` isn't a `bool`.
+    _ = select(1, 2, 9001);
+}
+",
+            "\
+error: Expected boolean expression for condition argument of `select`, got something else
+  ┌─ wgsl:4:9
+  │
+4 │     _ = select(1, 2, 9001);
+  │         ^^^^^^ see msg
+
+",
+        ),
+        (
+            "\
+@compute @workgroup_size(1, 1)
+fn main() {
+    // Bad: `bool` and abstract int args. don't match.
+    _ = select(true, 1, false);
+}
+",
+            "\
+error: Expected boolean expression for condition argument of `select`, got something else
+  ┌─ wgsl:4:9
+  │
+4 │     _ = select(true, 1, false);
+  │         ^^^^^^ see msg
+
+",
+        ),
+    ];
+
+    for (input, snapshot) in snapshots {
+        assert_parse_err(input, snapshot);
+    }
 }
 
 #[test]