WIP

Author: ErichDonGubler

naga/tests/naga/validation.rs

@@ -691,26 +691,6 @@ error: Function [1] 'main' is invalid
   │  \n  = Call to [0] is invalid
   = Requires 1 arguments, but 0 are provided
 
-",
-        ),
-        (
-            "\
-@compute @workgroup_size(1, 1)
-fn main() {
-    // Bad: `9001` isn't a `bool`.
-    _ = select(1, 2, 9001);
-}
-",
-            "\
-error: Entry point main at Compute is invalid
-  ┌─ wgsl:4:9
-  │
-4 │     _ = select(1, 2, 9001);
-  │         ^^^^^^ naga::ir::Expression [3]
-  │
-  = Expression [3] is invalid
-  = Expected selection condition to be a boolean value, got Scalar(Scalar { kind: Sint, width: 4 })
-
 ",
         ),
         (

naga/tests/naga/wgsl_errors.rs

@@ -2081,6 +2081,47 @@ fn select() {
         )
         if name.starts_with("select_")
     }
+
+    let snapshots = [
+        (
+            "\
+@compute @workgroup_size(1, 1)
+fn main() {
+    // Bad: `9001` isn't a `bool`.
+    _ = select(1, 2, 9001);
+}
+",
+            "\
+error: Expected boolean expression for condition argument of `select`, got something else
+  ┌─ wgsl:4:9
+  │
+4 │     _ = select(1, 2, 9001);
+  │         ^^^^^^ see msg
+
+",
+        ),
+        (
+            "\
+@compute @workgroup_size(1, 1)
+fn main() {
+    // Bad: `bool` and abstract int args. don't match.
+    _ = select(true, 1, false);
+}
+",
+            "\
+error: Expected boolean expression for condition argument of `select`, got something else
+  ┌─ wgsl:4:9
+  │
+4 │     _ = select(true, 1, false);
+  │         ^^^^^^ see msg
+
+",
+        ),
+    ];
+
+    for (input, snapshot) in snapshots {
+        assert_parse_err(input, snapshot);
+    }
 }
 
 #[test]