WIP: remove immediates feature

TODO: reconcile with the capability in Naga (which I think we want to
keep?).

Author: ErichDonGubler

examples/features/src/ray_shadows/mod.rs

@@ -82,7 +82,7 @@ fn create_matrix(config: &wgpu::SurfaceConfiguration) -> Uniforms {
 
 impl crate::framework::Example for Example {
     fn required_features() -> wgpu::Features {
-        wgpu::Features::EXPERIMENTAL_RAY_QUERY | wgpu::Features::IMMEDIATES
+        wgpu::Features::EXPERIMENTAL_RAY_QUERY
     }
 
     fn required_downlevel_capabilities() -> wgpu::DownlevelCapabilities {

tests/tests/wgpu-gpu/dispatch_workgroups_indirect.rs

@@ -16,7 +16,6 @@ pub fn all_tests(vec: &mut Vec<GpuTestInitializer>) {
 static NUM_WORKGROUPS_BUILTIN: GpuTestConfiguration = GpuTestConfiguration::new()
     .parameters(
         TestParameters::default()
-            .features(wgpu::Features::IMMEDIATES)
             .downlevel_flags(
                 wgpu::DownlevelFlags::COMPUTE_SHADERS | wgpu::DownlevelFlags::INDIRECT_EXECUTION,
             )

tests/tests/wgpu-gpu/immediates.rs

@@ -20,14 +20,10 @@ pub fn all_tests(vec: &mut Vec<GpuTestInitializer>) {
 /// will remain unchanged.
 #[gpu_test]
 static PARTIAL_UPDATE: GpuTestConfiguration = GpuTestConfiguration::new()
-    .parameters(
-        TestParameters::default()
-            .features(wgpu::Features::IMMEDIATES)
-            .limits(wgpu::Limits {
-                max_immediate_size: 32,
-                ..Default::default()
-            }),
-    )
+    .parameters(TestParameters::default().limits(wgpu::Limits {
+        max_immediate_size: 32,
+        ..Default::default()
+    }))
     .run_async(partial_update_test);
 
 const SHADER: &str = r#"

tests/tests/wgpu-gpu/regression/issue_3349.rs

@@ -29,14 +29,10 @@ pub fn all_tests(vec: &mut Vec<GpuTestInitializer>) {
 /// We then validate the data is correct from every position.
 #[gpu_test]
 static MULTI_STAGE_DATA_BINDING: GpuTestConfiguration = GpuTestConfiguration::new()
-    .parameters(
-        TestParameters::default()
-            .features(wgpu::Features::IMMEDIATES)
-            .limits(wgpu::Limits {
-                max_immediate_size: 16,
-                ..Default::default()
-            }),
-    )
+    .parameters(TestParameters::default().limits(wgpu::Limits {
+        max_immediate_size: 16,
+        ..Default::default()
+    }))
     .run_async(multi_stage_data_binding_test);
 
 async fn multi_stage_data_binding_test(ctx: TestingContext) {

tests/tests/wgpu-gpu/shader/struct_layout.rs

@@ -54,7 +54,6 @@ static STORAGE_INPUT: GpuTestConfiguration = GpuTestConfiguration::new()
 static IMMEDIATES_INPUT: GpuTestConfiguration = GpuTestConfiguration::new()
     .parameters(
         TestParameters::default()
-            .features(Features::IMMEDIATES)
             .downlevel_flags(DownlevelFlags::COMPUTE_SHADERS)
             .limits(Limits {
                 max_immediate_size: MAX_BUFFER_SIZE as u32,
@@ -633,7 +632,7 @@ static STORAGE_INPUT_INT64: GpuTestConfiguration = GpuTestConfiguration::new()
 static IMMEDIATES_INPUT_INT64: GpuTestConfiguration = GpuTestConfiguration::new()
     .parameters(
         TestParameters::default()
-            .features(Features::SHADER_INT64 | Features::IMMEDIATES)
+            .features(Features::SHADER_INT64)
             .downlevel_flags(DownlevelFlags::COMPUTE_SHADERS)
             .limits(Limits {
                 max_immediate_size: MAX_BUFFER_SIZE as u32,

wgpu-core/src/device/resource.rs

@@ -3685,9 +3685,9 @@ impl Device {
             });
         }
 
-        if desc.immediate_size != 0 {
-            self.require_features(wgt::Features::IMMEDIATES)?;
-        }
+        // if desc.immediate_size != 0 {
+        //     self.require_features(wgt::Features::IMMEDIATES)?;
+        // }
         if self.limits.max_immediate_size < desc.immediate_size {
             return Err(Error::ImmediateRangeTooLarge {
                 size: desc.immediate_size,

wgpu-core/src/indirect_validation/dispatch.rs

@@ -93,7 +93,7 @@ impl Dispatch {
         let module = panic!("Indirect validation requires the wgsl feature flag to be enabled!");
 
         let info = crate::device::create_validator(
-            wgt::Features::IMMEDIATES,
+            wgt::Features::empty(),
             wgt::DownlevelFlags::empty(),
             naga::valid::ValidationFlags::all(),
         )

wgpu-core/src/indirect_validation/draw.rs

@@ -531,7 +531,7 @@ fn create_validation_module(
     let module = panic!("Indirect validation requires the wgsl feature flag to be enabled!");
 
     let info = crate::device::create_validator(
-        wgt::Features::IMMEDIATES,
+        wgt::Features::empty(),
         wgt::DownlevelFlags::empty(),
         naga::valid::ValidationFlags::all(),
     )

wgpu-core/src/timestamp_normalization/mod.rs

@@ -151,7 +151,7 @@ impl TimestampNormalizer {
                 panic!("Timestamp normalization requires the wgsl feature flag to be enabled!");
 
             let info = crate::device::create_validator(
-                wgt::Features::IMMEDIATES,
+                wgt::Features::empty(),
                 wgt::DownlevelFlags::empty(),
                 naga::valid::ValidationFlags::all(),
             )

wgpu-hal/src/dx12/adapter.rs

@@ -473,7 +473,6 @@ impl super::Adapter {
             | wgt::Features::TEXTURE_COMPRESSION_BC_SLICED_3D
             | wgt::Features::CLEAR_TEXTURE
             | wgt::Features::TEXTURE_FORMAT_16BIT_NORM
-            | wgt::Features::IMMEDIATES
             | wgt::Features::PRIMITIVE_INDEX
             | wgt::Features::RG11B10UFLOAT_RENDERABLE
             | wgt::Features::DUAL_SOURCE_BLENDING