Skip to content

Commit 1d4891a

Browse files
[deno] Return undefined instead of null from Queue.submit (gfx-rs#7784)
1 parent 24f7796 commit 1d4891a

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

deno_webgpu/queue.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ use std::time::Duration;
77
use deno_core::cppgc::Ptr;
88
use deno_core::futures::channel::oneshot;
99
use deno_core::op2;
10+
use deno_core::v8;
1011
use deno_core::GarbageCollected;
1112
use deno_core::WebIDL;
1213
use deno_error::JsErrorBox;
@@ -53,8 +54,9 @@ impl GPUQueue {
5354
#[required(1)]
5455
fn submit(
5556
&self,
57+
scope: &mut v8::HandleScope,
5658
#[webidl] command_buffers: Vec<Ptr<GPUCommandBuffer>>,
57-
) -> Result<(), JsErrorBox> {
59+
) -> Result<v8::Local<v8::Value>, JsErrorBox> {
5860
let ids = command_buffers
5961
.into_iter()
6062
.enumerate()
@@ -75,7 +77,7 @@ impl GPUQueue {
7577
self.error_handler.push_error(Some(err));
7678
}
7779

78-
Ok(())
80+
Ok(v8::undefined(scope).into())
7981
}
8082

8183
#[async_method]

0 commit comments

Comments
 (0)