refactor!: move(process_reports): read reports, _then_ metadata

Author: ErichDonGubler

moz-webgpu-cts/src/process_reports.rs

@@ -176,93 +176,6 @@ pub(crate) fn process_reports(
     let mut other_entries_by_test = IndexMap::<TestEntryPath<'_>, TestEntry>::default();
     let old_meta_file_paths = meta_files_by_path.keys().cloned().collect::<Vec<_>>();
 
-    log::debug!("loading metadata for comparison to reports…");
-    for (path, file) in meta_files_by_path {
-        let File { properties, tests } = file;
-
-        let file_rel_path = path.strip_prefix(checkout).unwrap();
-
-        file_props_by_file.insert(
-            Utf8PathBuf::from(file_rel_path.to_str().unwrap()),
-            properties,
-        );
-
-        for (SectionHeader(name), test) in tests {
-            let Test {
-                properties,
-                subtests,
-            } = test;
-
-            let test_entry_path =
-                match TestEntryPath::from_metadata_test(browser, file_rel_path, &name) {
-                    Ok(ok) => ok,
-                    Err(e) => {
-                        log::error!("{e}");
-                        return Err(AlreadyReportedToCommandline);
-                    }
-                };
-
-            let freak_out_do_nothing =
-                |what: &dyn Display| log::error!("hoo boy, not sure what to do yet: {what}");
-
-            let mut reported_dupe_already = false;
-            let mut dupe_err = || {
-                if !reported_dupe_already {
-                    freak_out_do_nothing(&format_args!(
-                        concat!(
-                            "duplicate entry for {:?}",
-                            "discarding previous entries with ",
-                            "this and further dupes"
-                        ),
-                        test_entry_path
-                    ))
-                }
-                reported_dupe_already = true;
-            };
-
-            let TestEntry {
-                entry: test_entry,
-                subtests: subtest_entries,
-            } = if let Some(cts_path) = cts_path(&test_entry_path) {
-                let entry = entries_by_cts_path.entry(cts_path).or_default();
-                if let Some(_old) = entry
-                    .metadata_path
-                    .replace(test_entry_path.clone().into_owned())
-                {
-                    dupe_err();
-                }
-                &mut entry.entry
-            } else {
-                other_entries_by_test
-                    .entry(test_entry_path.clone().into_owned())
-                    .or_default()
-            };
-
-            let test_entry_path = &test_entry_path;
-
-            if let Some(_old) = test_entry.meta_props.replace(properties) {
-                dupe_err();
-            }
-
-            for (SectionHeader(subtest_name), subtest) in subtests {
-                let Subtest { properties } = subtest;
-                let subtest_entry = subtest_entries.entry(subtest_name.clone()).or_default();
-                if let Some(_old) = subtest_entry.meta_props.replace(properties) {
-                    if !reported_dupe_already {
-                        freak_out_do_nothing(&format_args!(
-                            concat!(
-                                "duplicate subtest in {:?} named {:?}, ",
-                                "discarding previous entries with ",
-                                "this and further dupes"
-                            ),
-                            test_entry_path, subtest_name
-                        ));
-                    }
-                }
-            }
-        }
-    }
-
     log::debug!("gathering reported test outcomes for reconciliation with metadata…");
 
     let (exec_reports_sender, exec_reports_receiver) = channel();
@@ -399,6 +312,93 @@ pub(crate) fn process_reports(
         }
     }
 
+    log::debug!("loading metadata for comparison to reports…");
+    for (path, file) in meta_files_by_path {
+        let File { properties, tests } = file;
+
+        let file_rel_path = path.strip_prefix(checkout).unwrap();
+
+        file_props_by_file.insert(
+            Utf8PathBuf::from(file_rel_path.to_str().unwrap()),
+            properties,
+        );
+
+        for (SectionHeader(name), test) in tests {
+            let Test {
+                properties,
+                subtests,
+            } = test;
+
+            let test_entry_path =
+                match TestEntryPath::from_metadata_test(browser, file_rel_path, &name) {
+                    Ok(ok) => ok,
+                    Err(e) => {
+                        log::error!("{e}");
+                        return Err(AlreadyReportedToCommandline);
+                    }
+                };
+
+            let freak_out_do_nothing =
+                |what: &dyn Display| log::error!("hoo boy, not sure what to do yet: {what}");
+
+            let mut reported_dupe_already = false;
+            let mut dupe_err = || {
+                if !reported_dupe_already {
+                    freak_out_do_nothing(&format_args!(
+                        concat!(
+                            "duplicate entry for {:?}",
+                            "discarding previous entries with ",
+                            "this and further dupes"
+                        ),
+                        test_entry_path
+                    ))
+                }
+                reported_dupe_already = true;
+            };
+
+            let TestEntry {
+                entry: test_entry,
+                subtests: subtest_entries,
+            } = if let Some(cts_path) = cts_path(&test_entry_path) {
+                let entry = entries_by_cts_path.entry(cts_path).or_default();
+                if let Some(_old) = entry
+                    .metadata_path
+                    .replace(test_entry_path.clone().into_owned())
+                {
+                    dupe_err();
+                }
+                &mut entry.entry
+            } else {
+                other_entries_by_test
+                    .entry(test_entry_path.clone().into_owned())
+                    .or_default()
+            };
+
+            let test_entry_path = &test_entry_path;
+
+            if let Some(_old) = test_entry.meta_props.replace(properties) {
+                dupe_err();
+            }
+
+            for (SectionHeader(subtest_name), subtest) in subtests {
+                let Subtest { properties } = subtest;
+                let subtest_entry = subtest_entries.entry(subtest_name.clone()).or_default();
+                if let Some(_old) = subtest_entry.meta_props.replace(properties) {
+                    if !reported_dupe_already {
+                        freak_out_do_nothing(&format_args!(
+                            concat!(
+                                "duplicate subtest in {:?} named {:?}, ",
+                                "discarding previous entries with ",
+                                "this and further dupes"
+                            ),
+                            test_entry_path, subtest_name
+                        ));
+                    }
+                }
+            }
+        }
+    }
+
     log::debug!("metadata and reports gathered, now reconciling outcomes…");
 
     let entries_by_cts_path = entries_by_cts_path.into_iter().map(|(_name, entry)| {